Skip to content

Conversation

@nxhafa
Copy link
Contributor

@nxhafa nxhafa commented Jan 8, 2026

Description

We have some flaky tests that occasionally fail on the pipelines. The purpose of this PR is to fix those flaky tests

Linked to #4239

Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

nxhafa and others added 23 commits December 15, 2025 10:53
Signed-off-by: nxhafa <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: nxhafa <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
…ime before the validation occurs

Signed-off-by: Andrea Tabone <[email protected]>
assertIfGatewayLogged(jwt, false, gatewayHosts[1]);
if (!(IS_MODULITH_ENABLED || ZAAS_CONF == null)) {
// Since we have only one ZAAS instance in the configuration, manually add the second one
assertIfZaasLogged(jwt, false, new ZaasConfiguration(ZAAS_CONF.getScheme(), ZAAS_CONF.getHost() + "-2", ZAAS_CONF.getPort(), 2));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work in internal systems? Since our hosts don't have the numbers. It could be a default when the second ZAAS instance is not defined in the environment-configuration.yml file, but if it is, it should prioritise it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

servicesEndpoint: gateway/api/v1/services
bucketCapacity: 20
authProvider: zosmf
connectionTimeout: 5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default may be defined in code only, just remember to add annotation to ignore missing properties in the GatewayServiceConfiguration class

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise other files that live outside this repository will fail

Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Sensitive Sensitive change that requires peer review size/L

Projects

Development

Successfully merging this pull request may close these issues.

4 participants