-
Notifications
You must be signed in to change notification settings - Fork 70
chore: Fix flaky tests #4449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3.x.x
Are you sure you want to change the base?
chore: Fix flaky tests #4449
Conversation
Signed-off-by: nxhafa <[email protected]>
Signed-off-by: nxhafa <[email protected]>
Signed-off-by: nxhafa <[email protected]>
Signed-off-by: nxhafa <[email protected]>
Signed-off-by: nxhafa <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
… ehcache fix Signed-off-by: nxhafa <[email protected]>
Signed-off-by: nxhafa <[email protected]>
Signed-off-by: nxhafa <[email protected]>
…ange Signed-off-by: nxhafa <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
…ime before the validation occurs Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
integration-tests/src/test/java/org/zowe/apiml/integration/proxy/StompProxyTest.java
Outdated
Show resolved
Hide resolved
| assertIfGatewayLogged(jwt, false, gatewayHosts[1]); | ||
| if (!(IS_MODULITH_ENABLED || ZAAS_CONF == null)) { | ||
| // Since we have only one ZAAS instance in the configuration, manually add the second one | ||
| assertIfZaasLogged(jwt, false, new ZaasConfiguration(ZAAS_CONF.getScheme(), ZAAS_CONF.getHost() + "-2", ZAAS_CONF.getPort(), 2)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this work in internal systems? Since our hosts don't have the numbers. It could be a default when the second ZAAS instance is not defined in the environment-configuration.yml file, but if it is, it should prioritise it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
integration-tests/src/test/resources/environment-configuration.yml
Outdated
Show resolved
Hide resolved
| servicesEndpoint: gateway/api/v1/services | ||
| bucketCapacity: 20 | ||
| authProvider: zosmf | ||
| connectionTimeout: 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the default may be defined in code only, just remember to add annotation to ignore missing properties in the GatewayServiceConfiguration class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise other files that live outside this repository will fail
Signed-off-by: Andrea Tabone <[email protected]>
Signed-off-by: Andrea Tabone <[email protected]>
|



Description
We have some flaky tests that occasionally fail on the pipelines. The purpose of this PR is to fix those flaky tests
Linked to #4239
Part of the # (epic)
Type of change
Please delete options that are not relevant.
Checklist:
For more details about how should the code look like read the Contributing guideline