Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions scripts/apiml-common-scripts.sh
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,12 @@ if [ "$(uname)" = "OS/390" ]; then

JAVA_VERSION=$(${JAVA_HOME}/bin/javap -J-Xms4m -J-Xmx16m -verbose java.lang.String \
| grep "major version" \
| cut -d " " -f5)
| awk '{print $NF}')
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the background of this change? Can you expand on what scenario breaks with the original code?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the changes introduced in PR #4482 and based on the initial round of testing, those characters were not present. However, last week, one of our teammates noticed the characters appearing at different location in log file while testing some other issue. I revalidated this on my end and confirmed that the characters are indeed present.
To further investigate the root cause, I’ve applied the above changes to examine whether an additional space delimiter might be getting introduced with the Java version. By using $NF, I was just testing out this suspicion.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update:- I tested this new changes as well, but still I can see those heliographic characters.


if [ $JAVA_VERSION -ge 65 ]; then # Java 21
# Default to 0 if parsing fails
JAVA_VERSION=${JAVA_VERSION:-0}

if [ "$JAVA_VERSION" -ge 65 ]; then # Java 21
ZOWE_CONSOLE_LOG_CHARSET=IBM-1047
# Java 21+ changed default encoding to UTF-8 (JEP 400). Set console encoding
# to EBCDIC for z/OS SYSPRINT to prevent garbled characters in early startup logs
Expand Down
Loading