Skip to content

chore: Fix caching service stability test for Modulith - #4544

Merged
pavel-jares-bcm merged 63 commits into
v3.x.xfrom
reboot/v3-fix-caching-stability-test-for-modulith
May 5, 2026
Merged

pavel-jares-bcm merged 63 commits into
v3.x.xfrom
reboot/v3-fix-caching-stability-test-for-modulith

Conversation

@pavel-jares-bcm

Copy link
Copy Markdown
Contributor

Description

This PR fixes JGroupStabilityTest. Before this change caching service was runing twice, but apiml service never. This fixes it. There are 4 tests (2 with CS and 2 with APIML), always a pair with and without AT-TLS. These 4 combination are all use cases that use different configuration of Infinispan.

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
@pull-request-size pull-request-size Bot added size/S and removed size/XS labels Apr 8, 2026
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
@pull-request-size pull-request-size Bot added size/M and removed size/S labels Apr 8, 2026
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
@pull-request-size pull-request-size Bot added size/S and removed size/M labels Apr 8, 2026
pavel-jares-bcm and others added 2 commits April 9, 2026 13:13
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
@EvaJavornicka EvaJavornicka modified the milestone: 3.5 Apr 17, 2026
pavel-jares-bcm and others added 4 commits April 17, 2026 17:32
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
Signed-off-by: nxhafa <nxhafa11@gmail.com>
@pull-request-size pull-request-size Bot added size/M and removed size/S labels Apr 24, 2026
@github-actions github-actions Bot added the Sensitive Sensitive change that requires peer review label Apr 24, 2026
@EvaJavornicka EvaJavornicka added this to the 3.5 milestone Apr 24, 2026
pavel-jares-bcm and others added 10 commits April 30, 2026 15:38
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
…ing/JGroupStabilityTest.java

Co-authored-by: Pablo Carle <pablocarle@users.noreply.github.com>
Signed-off-by: Pavel Jareš <58428711+pavel-jares-bcm@users.noreply.github.com>
…nfinispan/config/LazyCacheManager.java

Co-authored-by: Pablo Carle <pablocarle@users.noreply.github.com>
Signed-off-by: Pavel Jareš <58428711+pavel-jares-bcm@users.noreply.github.com>
…nfinispan/config/LazyCacheManager.java

Co-authored-by: Pablo Carle <pablocarle@users.noreply.github.com>
Signed-off-by: Pavel Jareš <58428711+pavel-jares-bcm@users.noreply.github.com>
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
…odulith

Signed-off-by: Pavel Jareš <58428711+pavel-jares-bcm@users.noreply.github.com>
@pablocarle

Copy link
Copy Markdown
Contributor

It may be worth to cover the if branch for modulith in InfinispanConfig

pavel-jares-bcm and others added 4 commits May 4, 2026 14:55
…ing/JGroupStabilityTest.java

Co-authored-by: Pablo Carle <pablocarle@users.noreply.github.com>
Signed-off-by: Pavel Jareš <58428711+pavel-jares-bcm@users.noreply.github.com>
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
…ing/JGroupStabilityTest.java

Co-authored-by: Pablo Carle <pablocarle@users.noreply.github.com>
Signed-off-by: Pavel Jareš <58428711+pavel-jares-bcm@users.noreply.github.com>
@sonarqubecloud

sonarqubecloud Bot commented May 5, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
65.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@pavel-jares-bcm
pavel-jares-bcm merged commit 0b209f0 into v3.x.x May 5, 2026
45 of 47 checks passed
@pavel-jares-bcm
pavel-jares-bcm deleted the reboot/v3-fix-caching-stability-test-for-modulith branch May 5, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Sensitive Sensitive change that requires peer review size/XL

Projects

Development

Successfully merging this pull request may close these issues.

6 participants