Create log files for components#173
Open
1000TurquoisePogs wants to merge 3 commits intov3.x/stagingfrom
Open
Conversation
…er HA instance Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, app-server & zss create log files.
Any other component or extension may or may not.
This causes people to think the log directory contains useful information, when it often doesnt.
This PR changes that by just having the launcher make log files for components.
The launcher already captures all output of components, so in this PR:
New property zowe.logging.rolloverCount is used to determine how many files to keep.
log files are named
<zowe.logDirectory>/<zowe.job.prefix>_<haInstance>_<component>_<timestamp>.logAs you can see from the screenshot, names are lengthy but unique.
This allows for 1 log folder to be used by multiple zowes.
I have not implemented, but setting rolloverCount to 0 or a similar option could be a way to disable logging entirely if desired???