Minor improvements in Connection classes#442
Merged
frankgiordano merged 1 commit intozowe:mainfrom Dec 26, 2025
Merged
Conversation
Signed-off-by: Shabaz K <kshabaz1729@gmail.com>
Contributor
Author
|
@frankgiordano please review this PR, added comments on reason for change |
shabaz213
commented
Dec 26, 2025
| if (port < 1 || port > 65535) { | ||
| throw new IllegalArgumentException("invalid port number: " + port); | ||
| } | ||
| this.port = port; |
Contributor
Author
There was a problem hiding this comment.
Validate then assign
shabaz213
commented
Dec 26, 2025
| "host='" + ((host == null) ? "" : host) + '\'' + | ||
| ", port='" + (port == 0 ? "" : port) + '\'' + | ||
| ", port='" + port + '\'' + | ||
| ", user='" + ((user == null) ? "" : user) + '\'' + |
Contributor
Author
There was a problem hiding this comment.
Not required as we already validate port to not be zero in constructor
shabaz213
commented
Dec 26, 2025
| * @param basePath string value | ||
| */ | ||
| void setBasePath(String basePath) { | ||
| if (basePath == null || basePath.isBlank()) |
Contributor
Author
There was a problem hiding this comment.
basePath will never be blank as we validate it in ZosConnectionFactory class
frankgiordano
approved these changes
Dec 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.