Pass basePath as constructor parameter#443
Merged
frankgiordano merged 1 commit intozowe:mainfrom Dec 27, 2025
Merged
Conversation
Signed-off-by: Shabaz K <kshabaz1729@gmail.com>
Contributor
Author
|
@frankgiordano please review this PR |
shabaz213
commented
Dec 26, 2025
| this.authType = authType; | ||
| } | ||
|
|
||
| private static void validatePort(String zosmfPort) { |
Contributor
Author
There was a problem hiding this comment.
extracted port validation logic to separate method
shabaz213
commented
Dec 26, 2025
| * @author Frank Giordano | ||
| */ | ||
| ZosConnection(final String host, final String zosmfPort, final AuthType authType) { | ||
| ZosConnection(final String host, final String zosmfPort, final String basePath, final AuthType authType) { |
Contributor
Author
There was a problem hiding this comment.
basePath is now initialized inside a constructor instead of setter method
shabaz213
commented
Dec 26, 2025
| assertNotEquals("string", conn); | ||
| } | ||
|
|
||
| @Test |
Contributor
Author
There was a problem hiding this comment.
Removed this test as it is now redundant. basePath is now immutable
frankgiordano
approved these changes
Dec 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.