Skip to content

Add semantic validation for user, group, file and directory - #578

Draft
1000TurquoisePogs wants to merge 1 commit into
v3.x/stagingfrom
feature/v3/semantic-validation
Draft

Add semantic validation for user, group, file and directory#578
1000TurquoisePogs wants to merge 1 commit into
v3.x/stagingfrom
feature/v3/semantic-validation

Conversation

@1000TurquoisePogs

@1000TurquoisePogs 1000TurquoisePogs commented Mar 17, 2026

Copy link
Copy Markdown
Member

For discussion.

This PR allows one to add "zoweValidate" to a json schema with values like "directoryExists".
This makes configmgr perform existence checks on the YAML value backed by the schema.

This is implemented by having function pointers in jsonschema.c which may be implemented, in this case, by configmgr.c
If jsonschema.c encounters a value for zoweValidate which nobody has implemented, it ignores it.
That is, it checks the schema as it would have without this PR.
But for any validator it does have, it calls the function and uses the boolean to determine if it should give an error or not.

image

Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@1000TurquoisePogs

Copy link
Copy Markdown
Member Author

When I spoke with Joe, he said it would be good to have an option in configmgr to bypass these checks, because we never know if someone's going to use configmgr in ways we didnt anticipate in which we want to not do such checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant