Add semantic validation for user, group, file and directory - #578
Draft
1000TurquoisePogs wants to merge 1 commit into
Draft
Add semantic validation for user, group, file and directory#5781000TurquoisePogs wants to merge 1 commit into
1000TurquoisePogs wants to merge 1 commit into
Conversation
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
|
Member
Author
|
When I spoke with Joe, he said it would be good to have an option in configmgr to bypass these checks, because we never know if someone's going to use configmgr in ways we didnt anticipate in which we want to not do such checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




For discussion.
This PR allows one to add "zoweValidate" to a json schema with values like "directoryExists".
This makes configmgr perform existence checks on the YAML value backed by the schema.
This is implemented by having function pointers in jsonschema.c which may be implemented, in this case, by configmgr.c
If jsonschema.c encounters a value for zoweValidate which nobody has implemented, it ignores it.
That is, it checks the schema as it would have without this PR.
But for any validator it does have, it calls the function and uses the boolean to determine if it should give an error or not.