Simplify example-zowe.yaml based on system symbols and internal references to avoid duplication of data#4601
Simplify example-zowe.yaml based on system symbols and internal references to avoid duplication of data#4601Joe-Winchester wants to merge 1 commit intov3.x/stagingfrom
Conversation
Signed-off-by: Joe Winchester <winchest@uk.ibm.com>
|
build 9264 SUCCEEDED. |
|
Test workflow 7868 is started. |
| job: | ||
| # Zowe JES job name | ||
| name: ZWE1SV | ||
| name: "${{ std.getenv('ZWE_components_gateway_port') }}SV" |
There was a problem hiding this comment.
@Joe-Winchester I think this references the wrong value, e.g., "7554SV".
Let's use the zowe job prefix:
name: "${{ std.getenv('ZWE_zowe_job_prefix') }}SV"|
In general we've kept templated variables and template logic in the For the values which users must supply and there's no advantage to defaults ( Last item, configmgr supports symbol resolution via Interested in others' opinions cc @1000TurquoisePogs @Martin-Zeithaml |
|
I thought I'd tested these changes, but just re-started the STC I was testing with and are getting some errors on the network port and ttls values, that seem to enforce integers and bools respectively, so they don't like the yaml lookups. I'm thinking of maybe setting the attls client to false by default, but having the external port match the gateway port seems like a good idea so I'll add to the PR to relax the integer enforcement. I hadn't thought about the |
Bulletproof definitionAny embedded value must be written in bulletproof form, like what if nothing is defined, is returned value valid etc.
ReadabilityLet's consider the previous example should be like this: Is this easy to read for every customer? AccessibilityIs every |
|
This is incompatible with containers and thus some consideration for containers is needed, such as to take an old example and shove it into |
| # Only include the two lines below that control the min and max TLS if 'attls: false' above | ||
| minTls: "TLSv1.2" | ||
| maxTls: "TLSv1.3" | ||
| client: |
There was a problem hiding this comment.
the easiest solution for 'client' is just to get rid of it from the example.
it's an advanced option, and, allowing attls to be toggled on just client was a mistake so i think our code doesnt even respect it now.
| # >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> | ||
| caching-service: | ||
| enabled: true | ||
| enabled: false |
There was a problem hiding this comment.
this has little effect in staging since it's forced on within apiml modulith.
a better simplification would be to remove attributes of apiml components which arent used in modulith, such as port. i would leave that to APIML devs to determine how best to refine.
|
use of templates, and certain templates, are not backward compatible for certain zwe phases. That is, you can't use this file on an older version of zowe when doing an install, but you probably could at runtime. some people may have v2 and v3, or various v3 versions, or want to do a downgrade, and encounter errors. i would like to improve things, but we must be careful of what should wait for v4 and what can be done now. we need to know what impact changes will have. |
|
Also see #4605 |
|
Lots of great feedback - thank you ! is worth keeping, as I don't see why anyone would not want the two values to be in sync ? |
PR type
What type of changes does your PR introduce to Zowe? Put an
xin the box that applies to this PR. If you're unsure about any of them, don't hesitate to ask.Relevant issues
Fixes #4600
Does this PR introduce a breaking change?
Does this PR add or change a YAML parameter?