Open
Conversation
Signed-off-by: MarkAckert <35308966+MarkAckert@users.noreply.github.com>
Signed-off-by: MarkAckert <35308966+MarkAckert@users.noreply.github.com>
Signed-off-by: MarkAckert <35308966+MarkAckert@users.noreply.github.com>
Signed-off-by: MarkAckert <35308966+MarkAckert@users.noreply.github.com>
Signed-off-by: MarkAckert <35308966+MarkAckert@users.noreply.github.com>
Signed-off-by: MarkAckert <35308966+MarkAckert@users.noreply.github.com>
Signed-off-by: MarkAckert <35308966+MarkAckert@users.noreply.github.com>
|
Client artifacts: |
Signed-off-by: MarkAckert <35308966+MarkAckert@users.noreply.github.com>
Signed-off-by: MarkAckert <35308966+MarkAckert@users.noreply.github.com>
Signed-off-by: MarkAckert <35308966+MarkAckert@users.noreply.github.com>
Signed-off-by: MarkAckert <35308966+MarkAckert@users.noreply.github.com>
Signed-off-by: MarkAckert <35308966+MarkAckert@users.noreply.github.com>
Signed-off-by: MarkAckert <35308966+MarkAckert@users.noreply.github.com>
Signed-off-by: MarkAckert <35308966+MarkAckert@users.noreply.github.com>
Signed-off-by: MarkAckert <35308966+MarkAckert@users.noreply.github.com>
Signed-off-by: MarkAckert <35308966+MarkAckert@users.noreply.github.com>
anaxceron
reviewed
Feb 13, 2026
|
|
||
| ## `0.2.3` | ||
|
|
||
| - `c`: Implement `zowex uss copy` command to copy USS files and directories. |
Contributor
There was a problem hiding this comment.
- Please change verb to past tense: Implemented ...
- Add an issue or PR link
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




What It Does
Adds a
zowex uss copycommand which is essentially a pass-through for the UNIXcpcommand utility. There are a few key differences fromcp:This command does not support arbitrary
cpcommand flags. It surfaces a few USS-related flags (-R,-L,-p).Currently,
uss copyalways uses-pby default, which is not the default behavior for USScp. The-pflag preserves file and directory attributes in the output directory, which was requested as part of Implement copy for USS files and directories #379. If this flag is unset, copied files appear to match the permission structure of the current directory.755directory with fileabcset to777, runningcp abc defyields a file with755permissions. runningcp -p abc defyieldsdefwith777permissions.Globbing and special characters will not be supported.
zowe uss copy abc* def, the glob is expanded before reaching our code, and the command will fail if there is >1 match forabc*(too many arguments).copy uss copy "abc*" def, the*is a character literal and the command looks for the exact file matchingabc*.Copy to/from datasets is currently possible, but not practical since this command doesn't surface
cpflags related to dataset handling. I'm not explicitly scanning the input parameters for DS syntax and erroring out.run_shell_commandis moved fromztso.cppintozut.cpp( Z Utilities?).I have a few implementation questions left:
cpexactly, or should we default to-p?-pby default, what should the flag to disable it be called? We currently block flags/arguments from usingnoas a prefix.-fflag? (Attempts to remove and replace destination files that can't be opened, which happens when a destination's files are read-only and won't be overwritten).Testing complete. Some unknowns:
zuttest case forrun_shell_commandnot capturing stdout? Is this an issue everywhere or just in the test case?How to Test
Run the zusf and zowex uss test cases.
Review Checklist
I certify that I have:
Additional Comments
Comments in
What it doessection.