Fix `z:python:test` + add architecture docs by zFernand0 · Pull Request #1121 · zowe/zowex

zFernand0 · 2026-08-27T01:56:22Z

What It Does

removes unnecessary python related scripts
adds architecture documentation
adds python test results

How to Test

Check the:

Review Checklist
I certify that I have:

tested my changes
added/updated automated tests
updated the changelog
followed the contribution guidelines

Additional Comments

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

+  ctx.encoding_opts.data_type = codepage == "binary" ? eDataTypeBinary : eDataTypeText;
+  std::string encoded = codepage;
+  a2e_inplace(encoded);
+  strncpy(ctx.encoding_opts.codepage, encoded.c_str(), sizeof(ctx.encoding_opts.codepage) - 1);


+
+  std::string encoded = etag;
+  a2e_inplace(encoded);
+  strncpy(ctx.etag, encoded.c_str(), sizeof(ctx.etag) - 1);


github-actions · 2026-08-27T01:59:36Z

Server artifacts:

PAX: https://github.com/zowe/zowex/actions/runs/33178849460/artifacts/9688929899

github-actions · 2026-08-27T01:59:50Z

Client artifacts:

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

…d other info Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

zFernand0 · 2026-08-28T12:02:58Z

🐍 Precompiled Python bindings

Built from fcba0af0 on z/OS.

📦 Download zbind_bin_dist-pr1121-fcba0af0.tar.gz

_{Hosted as an asset on the py-bindings-dev prerelease (dev artifact, not for distribution).}

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

…afterwards Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

zFernand0 · 2026-08-28T13:15:13Z

Failing tests:

=========================== short test summary info ============================
FAILED test_zjb_utf8.py::TestJobFunctions::test_get_job_jcl_success - Runtime...
FAILED test_zjb_utf8.py::TestJobFunctions::test_delete_job_success - RuntimeE...
FAILED test_zjb_utf8.py::TestJobFunctions::test_job_workflow_integration - Ru...
========================= 3 failed, 6 passed in 6.53s ==========================

UPDATE:

All fixed

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

        run: npm run z:python:test

+      - name: Python Test Report
+        uses: dorny/test-reporter@v2


…into zf/fix-py-test Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

sonarqubecloud · 2026-09-03T19:04:18Z

Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

traeok

Thanks for all your work on this Fernando! Left a few suggestions

traeok · 2026-09-04T12:56:50Z

+	@$(MAKE) test-zds 2>&1 | tee -a $(RESULTS_FILE) || touch .tests_failed
+	@$(MAKE) test-zjb 2>&1 | tee -a $(RESULTS_FILE) || touch .tests_failed
+	@$(MAKE) test-zusf 2>&1 | tee -a $(RESULTS_FILE) || touch .tests_failed
+	@$(MAKE) merge-results


Nit: I see the comment above this implies that the teardown always runs even if a stage fails, but it looks like if merge-results fails, it would abort make test. Consider updating the @$(MAKE) merge-results line to follow the pattern of the previous lines, so a partial report is still generated if something fails.

Suggested change

@$(MAKE) merge-results

@$(MAKE) merge-results || touch .tests-failed

Then you may need to update the inline script for merge-results (see comment below)

traeok · 2026-09-04T12:57:17Z

+
+# Combines the per-suite JUnit reports into a single file so CI only needs to retrieve/publish one report
+merge-results:
+	@$(PY_ENV)/bin/python -c "import sys, xml.etree.ElementTree as ET; root = ET.Element('testsuites'); [root.append(s) for f in sys.argv[2:] for s in ET.parse(f).getroot()]; ET.ElementTree(root).write(sys.argv[1], xml_declaration=True, encoding='UTF-8')" $(JUNIT_ALL) $(JUNIT_ZDS) $(JUNIT_ZJB) $(JUNIT_ZUSF)


Following up on the suggestion above, consider updating this script so that sys.argv[2:] is validated using os.path.exists 👍

traeok · 2026-09-04T12:59:09Z

+                extra_postargs = list(extra_postargs) + [EBCDIC_CHAR_MODE]
+            return base_compile(obj, src, src_ext, cc_args, extra_postargs, pp_opts)
+
+        compiler._compile = _compile


I know we can probably make some assumptions about the distutils APIs, but since this monkey-patched function is private, consider checking first with hasattr before overwriting it.

Suggested change

compiler._compile = _compile

if hasattr(compiler, "_compile"):

compiler._compile = _compile

traeok · 2026-09-04T13:00:42Z

Seems like the time budget could be a bit tight here for timing out the workflow (currently, the workflow is set to time out after 20min) - should we consider increasing the timeout in this PR?

traeok · 2026-09-04T13:02:26Z

Thanks for making the updates to the USS functions to handle EBCDIC<->ASCII 😋
Should we add a changelog entry to capture this fix?

zFernand0 added 4 commits August 26, 2026 20:09

fix(native): use C linkage for everything used by pythong bindings

280c1f5

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

fix(python): compile shared native sources as EBCDIC

50e234e

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

fix(python): follow the same a2e pattern for zusf

df68971

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

doc(arch): add proper architecture info

0ebc286

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

github-project-automation Bot added this to Zowe CLI Squad Aug 27, 2026

github-project-automation Bot moved this to New Issues in Zowe CLI Squad Aug 27, 2026

pull-request-size Bot added the size/L label Aug 27, 2026

zowe-robot moved this from New Issues to In Progress in Zowe CLI Squad Aug 27, 2026

github-actions Bot assigned zFernand0 Aug 27, 2026

github-advanced-security Bot found potential problems Aug 27, 2026

View reviewed changes

zFernand0 changed the title ~~Zf/fix py test~~ Fix z:python:test + add architecture docs Aug 27, 2026

zFernand0 added 6 commits August 26, 2026 22:03

fix(python): address ds related tests

2ac321e

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

feat(python): add show_attributes so that we can get volser, recfm an…

71ea28c

…d other info Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

fix(python): forgot to update the tests 😢

b4498ca

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

fix(python): And also forgot about the readme 😢

72c9a71

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

fix(python): fix zjb_py's job default prefix and use '*' isntead

0bc7d7f

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

docs(python): update changelog

fcba0af

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

pull-request-size Bot added size/XL and removed size/L labels Aug 28, 2026

zFernand0 added 3 commits August 28, 2026 08:21

fix(python): update CI to install swig if not available

fb9c8f8

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

ci(python): forgot to build the entire project since we run z:delete …

78f6438

…afterwards Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

ci(python): suppress deprecation warning and add env.yml fixture

5a0109a

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

github-advanced-security Bot found potential problems Aug 28, 2026

View reviewed changes

Comment thread .github/workflows/zos-py-build.yml Fixed

Comment thread .github/workflows/zos-py-build.yml Fixed

ci(python): typo - missing directory

c3259d2

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

zFernand0 added 2 commits August 28, 2026 09:45

ci(python): generate test results for python bindings

09637c2

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

fix(python): try to fix jobs unit test

3c9e86d

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

github-advanced-security Bot found potential problems Aug 28, 2026

View reviewed changes

Comment thread .github/workflows/zos-py-build.yml

run: npm run z:python:test

- name: Python Test Report

uses: dorny/test-reporter@v2

zFernand0 requested review from CBforZ, dkelosky, pujal0909, t1m0thyj and traeok August 28, 2026 15:57

zFernand0 marked this pull request as ready for review August 28, 2026 15:57

zowe-robot moved this from In Progress to Review/QA in Zowe CLI Squad Aug 28, 2026

Merge branch 'zf/fix-py' of https://github.com/zowe/zowe-native-proto …

3fb3565

…into zf/fix-py-test Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

traeok reviewed Sep 4, 2026

View reviewed changes

Navigation Menu

Uh oh!

Fix `z:python:test` + add architecture docs - #1121

Fix `z:python:test` + add architecture docs#1121
zFernand0 wants to merge 17 commits into
zf/fix-pyfrom
zf/fix-py-test

zFernand0 commented Aug 27, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 27, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 27, 2026 •

edited

Loading

Uh oh!

zFernand0 commented Aug 28, 2026

Uh oh!

Uh oh!

Uh oh!

zFernand0 commented Aug 28, 2026 •

edited

Loading

Uh oh!

sonarqubecloud Bot commented Sep 3, 2026

Uh oh!

traeok left a comment

Uh oh!

traeok Sep 4, 2026

Uh oh!

traeok Sep 4, 2026

Uh oh!

traeok Sep 4, 2026

Uh oh!

traeok Sep 4, 2026

Uh oh!

traeok Sep 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	@$(MAKE) merge-results
	@$(MAKE) merge-results \|\| touch .tests-failed

	compiler._compile = _compile
	if hasattr(compiler, "_compile"):
	compiler._compile = _compile

Uh oh!

Conversation

zFernand0 commented Aug 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zFernand0 commented Aug 28, 2026

🐍 Precompiled Python bindings

Uh oh!

Uh oh!

Uh oh!

zFernand0 commented Aug 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud Bot commented Sep 3, 2026

Quality Gate failed

Uh oh!

traeok left a comment

Choose a reason for hiding this comment

Uh oh!

traeok Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

traeok Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

traeok Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

traeok Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

traeok Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

zFernand0 commented Aug 27, 2026 •

edited

Loading

github-actions Bot commented Aug 27, 2026 •

edited

Loading

github-actions Bot commented Aug 27, 2026 •

edited

Loading

zFernand0 commented Aug 28, 2026 •

edited

Loading