Conversation
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
| } | ||
|
|
||
| #define NUM_DELETE_TEXT_UNITS 2 | ||
| int zds_delete_member(ZDS *zds, std::string dsn, std::string member) |
There was a problem hiding this comment.
one thing I wonder about if this new portion should be at the ds.cpp layer in the same way the iebcopy is at that layer. I dont see a specific hard in the current implementation, but was thinking that the zds.cpp layer would be for more programmatic APIs.
Otherwise, it feels like this makes sense. I was also surprised to see (TIL) that deleting a member via ISPF is supported while that same member is open for browse in another ISPF screen.
There was a problem hiding this comment.
I can move it to commands/ds.cpp if we prefer. As you said it would be consistent with invoking IEBCOPY at that layer for the zowex ds compress command.
However if I remove it from zds.cpp, then we won't be providing a function for users of our C++ libraries to delete members without exclusively allocating their parent PDS. Are we ok with this?
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
| [&]() -> void | ||
| { | ||
| std::string ds = _ds.back(); | ||
| _create_ds(ds, "--dsorg PO --dirblk 2"); |
traeok
left a comment
There was a problem hiding this comment.
Going to test now but left a suggestion about building the DDs 👍
Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
|
This seems too permissive - it allows a member to be deleted even when its open in ISPF mode, while z/OSMF does not because the data set has an ENQ. |
Perhaps the existing behavior is more desirable anyway? That is maybe it’s good thing the delete fails, and we can give a clearer error message |
I'm confused, 😕 We want to keep the behavior as-is, i.e. fail when the PDS (not the member) is open in either mode (browse, view, edit) in ISPF. |
|
My vote would be to provide a better error message to surface the conflict. |
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
c237f06 to
6f361b5
Compare
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
|




What It Does
Fixes #916
How to Test
Review Checklist
I certify that I have:
Additional Comments