fix(vsce): Don't swallow errors for createDataset - #927
Conversation
c7495eb to
b3a4f4c
Compare
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
26e691d to
592f36c
Compare
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
ff78ed7 to
9afba0b
Compare
traeok
left a comment
traeok
left a comment
There was a problem hiding this comment.
Are there steps to test for this PR or is this just meant to be merged in as-is (as main is not the base)? I am seeing the same error message, wasn't sure if I was missing something
| } | ||
| const response = await (await this.client).ds.createMember({ | ||
| dsname: dataSetName, | ||
| overwrite: true, // Overwrite detection already handled on client side |
There was a problem hiding this comment.
(nit) I understand the premise of the comment, but in the future I wonder if this is better suited for the TSDoc within Zowe Explorer API's extender interfaces. The comment is definitely accurate, but this isn't behavior exclusive to ZRS, and this info could help steer other extenders that implement this function.
There was a problem hiding this comment.
This is a good point, but after discussing offline I'm not sure that it warrants a separate PR for Zowe Explorer at this time 😋
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
|
7 participants
What It Does
Fixes #917 - note that some DS operations now show 2 error messages instead of 1, but this is consistent with how other APIs behave and should be resolved once ZRS is merged into ZE.
How to Test
Review Checklist
I certify that I have:
Additional Comments