Add --overwrite option to creation commands by t1m0thyj · Pull Request #938 · zowe/zowex

t1m0thyj · 2026-04-14T14:59:22Z

What It Does

Fixes #642

How to Test

Run the following commands with and without the --overwrite flag:

zowex ds create-member {pdsWithMemberThatExists}
zowex uss create-file {filePathThatExists}

Also try with the VSCE to create PDS members and USS files that already exist. For data sets, you should be prompted to replace. For USS, you should see an error. This behavior matches z/OSMF.

Review Checklist
I certify that I have:

tested my changes
added/updated automated tests
updated the changelog
followed the contribution guidelines

Additional Comments

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>

github-actions · 2026-04-14T15:01:08Z

Client artifacts:

CLI Plug-in: https://github.com/zowe/zowex/actions/runs/24572560016/artifacts/6498986990
VSCode Extension: https://github.com/zowe/zowex/actions/runs/24572560016/artifacts/6498987336
SDK: https://github.com/zowe/zowex/actions/runs/24572560016/artifacts/6498987678

dkelosky · 2026-04-14T15:17:27Z


 int zusf_copy_file_or_dir(ZUSF *zusf, const std::string &source_fs, const std::string &dest_fs, const CopyOptions &options);
-int zusf_create_uss_file_or_dir(ZUSF *zusf, const std::string &file, mode_t mode, bool createDir);
+int zusf_create_uss_file_or_dir(ZUSF *zusf, const std::string &file, mode_t mode, bool createDir, bool overwrite = false);


perhaps this is a good time to add an options struct?

Resolved in 1100c36

Should we be concerned about this being a breaking change?

If so, I could add back an overload for passing create_dir parameter to keep backward compatibility.

No concerns here

dkelosky · 2026-04-14T15:18:43Z

+    if (!overwrite && zds_member_exists(dataset_name, member_name))
+    {
+      context.error_stream() << "Error: could not create data set member: '" << member_name << "' rc: '" << RTNCD_FAILURE << "'" << std::endl;
+      context.error_stream() << "  Details: Data set member already exists: '" << dsn << "'" << std::endl;


can we hint that the user should specify an overwrite

I like this idea, but am on the fence about how it would come across to users of the VS Code extension - if we suggest to pass the --overwrite flag that will only be applicable for zowex CLI.

I see. Two thoughts in response:

perhaps this should be a warning condition instead of a failure?

how would the VS Code extension indicate the overwrite behavior?

Discussed offline - plan to make it a warning, but no need to support overwrite from the VSCE at this time.

Should we call it replace to match VSCE behavior?

We show the same prompt for SSH profiles in the VSCE. Is the suggestion to rename the --overwrite flag on the CLI command?

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>

sonarqubecloud · 2026-04-17T15:18:12Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

anaxceron · 2026-04-17T15:19:51Z

 - `c`: Added the `getInfo` RPC to retrieve the middleware version and build information. [#922](https://github.com/zowe/zowex/pull/922)
 - `c`: Added a DCB abend exit for handling edge cases around PDS member open, write, and close operations. When an abend is encountered, it is either delayed or ignored (when applicable) and an error is returned gracefully via the diagnostic structure (`ZDIAG`) rather than terminating the process. Refer to [DCB abend exits](doc/dcb-abend-exit.md) for more information on how and when abends are handled. **Note:** In the event of an end-of-space (end-of-volume) abend, the operating system closes the DCB if the ignore request is honored from the abend exit. However, the abend might still percolate during end-of-volume `CLOSE` routines. An ESTAE/ESTAEX recovery routine should be used to gracefully handle these cases. [#839](https://github.com/zowe/zowex/issues/839)
 - `c`: Fixed an issue where listing the members of a protected, partitioned data set resulted in an unclear error message. Now, the error messages are more specific and include information about insufficient permissions when applicable. [#297](https://github.com/zowe/zowex/issues/297)
+- `c`: Fixed an issue where `zowex ds create-member` command would overwrite an existing member. Added an `--overwrite` flag to the command that defaults to false. [#642](https://github.com/zowe/zowex/issues/642)


Suggested change

- `c`: Fixed an issue where `zowex ds create-member` command would overwrite an existing member. Added an `--overwrite` flag to the command that defaults to false. [#642](https://github.com/zowe/zowex/issues/642)

- `c`: Fixed an issue where the `zowex ds create-member` command would overwrite an existing member. Added an `--overwrite` flag to the command that defaults to false. [#642](https://github.com/zowe/zowex/issues/642)

anaxceron · 2026-04-17T15:23:37Z

 ## Recent Changes

 - **Breaking:** Renamed contributed setting IDs from `zowe-native-proto` to `zowex`. All references to `zowe-native-proto` should be replaced with `zowex` in VS Code `settings.json` files. [#831](https://github.com/zowe/zowex/issues/831)
+- Fixed an error when creating a member that already exists if the "Replace" option is selected. [#642](https://github.com/zowe/zowex/issues/642)


Suggested change

- Fixed an error when creating a member that already exists if the "Replace" option is selected. [#642](https://github.com/zowe/zowex/issues/642)

- Fixed an error that would overwrite a member that already existed when creating a member with the "Replace" option. [#642](https://github.com/zowe/zowex/issues/642)

Add --overwrite option to creation commands

9531342

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>

github-project-automation bot added this to Zowe CLI Squad Apr 14, 2026

github-project-automation bot moved this to New Issues in Zowe CLI Squad Apr 14, 2026

pull-request-size bot added the size/M label Apr 14, 2026

zowe-robot moved this from New Issues to In Progress in Zowe CLI Squad Apr 14, 2026

github-actions bot assigned t1m0thyj Apr 14, 2026

dkelosky reviewed Apr 14, 2026

View reviewed changes

Refactor to use CreateOptions struct

1100c36

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>

pull-request-size bot added size/L and removed size/M labels Apr 16, 2026

t1m0thyj added 2 commits April 16, 2026 16:23

Handle overwrite detection in vsce

8bbac0a

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>

Add system tests for overwrite warnings

7c8f2b5

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>

t1m0thyj linked an issue Apr 17, 2026 that may be closed by this pull request

zowex(ds): zowex ds create-member may cause data-loss #642

Open

jace-roell and others added 2 commits April 17, 2026 10:55

Merge branch 'main' into fix/add-overwrite-flag

6cc9b5c

Update changelogs

21d8386

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>

t1m0thyj requested review from ATorrise, MarkAckert, anaxceron, awharn, dkelosky, jace-roell, pujal0909, traeok and zFernand0 April 17, 2026 15:17

t1m0thyj marked this pull request as ready for review April 17, 2026 15:18

zowe-robot moved this from In Progress to Review/QA in Zowe CLI Squad Apr 17, 2026

anaxceron reviewed Apr 17, 2026

View reviewed changes

	- `c`: Fixed an issue where `zowex ds create-member` command would overwrite an existing member. Added an `--overwrite` flag to the command that defaults to false. [#642](https://github.com/zowe/zowex/issues/642)
	- `c`: Fixed an issue where the `zowex ds create-member` command would overwrite an existing member. Added an `--overwrite` flag to the command that defaults to false. [#642](https://github.com/zowe/zowex/issues/642)

	- Fixed an error when creating a member that already exists if the "Replace" option is selected. [#642](https://github.com/zowe/zowex/issues/642)
	- Fixed an error that would overwrite a member that already existed when creating a member with the "Replace" option. [#642](https://github.com/zowe/zowex/issues/642)

Conversation

t1m0thyj commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pujal0909 Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Apr 17, 2026

Quality Gate passed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

t1m0thyj commented Apr 14, 2026 •

edited

Loading

github-actions bot commented Apr 14, 2026 •

edited

Loading

pujal0909 Apr 15, 2026 •

edited

Loading