Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
| options->member_created = true; | ||
| } | ||
| control_stmt = " COPY OUTDD=SYSUT2,INDD=SYSUT1\n"; | ||
| control_stmt += " SELECT MEMBER=((" + sourceInfo.member_name + "," + targetInfo.member_name + replace_flag + "))"; |
There was a problem hiding this comment.
does this allow me to copy something like "SYS1.MACLIB(A*)" and copy all members that start with an A ?
There was a problem hiding this comment.
No this implementation won't allow copying multiple members. It can be added as a future enhancement?
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
zFernand0
left a comment
zFernand0
left a comment
There was a problem hiding this comment.
Changes are LGTM! 😋
I'll continue testing to see what's going on with the S0C4s 😋
Left some comments for awareness 🙏
| ds_copy_cmd->add_keyword_arg("overwrite", make_aliases("-o"), | ||
| "Replace the entire target partitioned data set with the source data set. All members including like named members will be overwritten", | ||
| ArgType_Flag, false, ArgValue(false)); | ||
| ds_copy_cmd->add_keyword_arg("delete-target-members", make_aliases("--delete-target-members", "-d"), | ||
| "delete all members from target PDS before copying (PDS-to-PDS copy only, makes target match source exactly)", | ||
| ds_copy_cmd->add_keyword_arg("replace", make_aliases("--replace", "-r"), | ||
| "Replaces target sequential/member content with source content or replaces matching members in a partitioned data set with source members (keeps non-matching target members)", |
There was a problem hiding this comment.
When we add a changelog entry, we should probably not that this is kind of "breaking" 😋
| int rc = copy_sequential(zds, src_mem_dsn, dst_mem_dsn); | ||
| if (rc != RTNCD_SUCCESS) | ||
| return rc; | ||
| static int copy_sequential(ZDS *zds, const std::string &dsn1, const std::string &dsn2, ZDSCopyOptions *options) |
There was a problem hiding this comment.
| } | ||
|
|
||
| if (options.target_created) | ||
| if (!options.target_exists && !options.member_created) |
There was a problem hiding this comment.
This may cause a small conflict with #920
Here is a full list of conflicting files, but that's just because the copy-frontend branch is not up to date with main
pujal0909
force-pushed
the
copy-refactor
branch
from
1662d20 to
97a3329
Compare
|
5 participants
What It Does
Backend now uses IEBGENER for copying PS to PS and IEBCOPY for copying PDS to PDS and member to member
How to Test
Review Checklist
I certify that I have:
Additional Comments