Upgrade CMake min ver to 3.13.#77
Merged
zpl-zak merged 1 commit intozpl-c:masterfrom Jun 2, 2025
nitrix:fix/upgrade-cmake-313
Merged
Upgrade CMake min ver to 3.13.#77zpl-zak merged 1 commit intozpl-c:masterfrom nitrix:fix/upgrade-cmake-313
zpl-zak merged 1 commit intozpl-c:masterfrom
nitrix:fix/upgrade-cmake-313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This upgrades the CMake minimum version to 3.13.
Why
Version 3.0 is no longer supported by newer toolchains and fails to build.
Exhibit
Considerations
While upgrading to something barely above 3.5+ to satisfy the requirements would work, there has been a similar upgrade done recently in CGLM (see recp/cglm#430) from
3.8.2to3.13.0and provides a lot more context why specifically3.13.0is more desirable. The defaults with set()/option() are less surprising and don't risk breaking backwards compatibility as something far newer could.