fix: (Moonlander) User code not called and Oryx status not updated on layer switch with MOONLANDER_USER_LEDS defined#410
Open
jacostro wants to merge 1 commit intozsa:firmware24from
Conversation
|
Looks sensible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
MOONLANDER_USER_LEDSsymbol is defined,layer_state_set_userandlayer_state_set_oryxare not called, hence:Description
Moved calls outside of
#if !defined(MOONLANDER_USER_LEDS)block, keepinglayer_state_set_oryxdependent onORYX_ENABLEDdefinition.Types of Changes