Skip to content

Update .NET code to .Net 7 and CPP FFMPEG deprecated code fixes#5

Open
Zekiah-A wants to merge 7 commits intozsbzsb:masterfrom
Zekiah-A:master
Open

Update .NET code to .Net 7 and CPP FFMPEG deprecated code fixes#5
Zekiah-A wants to merge 7 commits intozsbzsb:masterfrom
Zekiah-A:master

Conversation

@Zekiah-A
Copy link

@Zekiah-A Zekiah-A commented Mar 24, 2023

Also includes some clean-ups to conform modern .Net code style patterns + attempt to update deprecated funcs in CPP source to newer code that works with modern ffmpeg

@Zekiah-A Zekiah-A changed the title Update .NET code to .Net 7 and latest SFML version support Update .NET code to .Net 7 and CPP FFMPEG deprecated code fixes Mar 24, 2023
@Zekiah-A Zekiah-A marked this pull request as draft March 25, 2023 15:03
@Zekiah-A Zekiah-A marked this pull request as ready for review March 25, 2023 15:48
@eXpl0it3r
Copy link

Wouldn't it make more sense for a library to keep things on the current LTS for .NET, which would be .NET 6?

@Zekiah-A
Copy link
Author

Wouldn't it make more sense for a library to keep things on the current LTS for .NET, which would be .NET 6?

Fair, fortunately this code should all be .net 6 compatible, but for project compatibility sake, I can go and change the project file so that it will be able to be used with all such .net 6 projects file.

@Zekiah-A
Copy link
Author

There are a few other things that I think I would like to see changed in this project, such as making sure this can properly be used as a nuget package, but I'll leave that to a later PR

@eXpl0it3r
Copy link

Unfortunately, I'm neither owner nor collaborator, would be great to see some movement on this repo. Maybe @zsbzsb is willing to add you to the repo 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants