Add cursor-containing-brackets highlighting#778
Open
rolandwalker wants to merge 2 commits intozsh-users:masterfrom
Open
Add cursor-containing-brackets highlighting#778rolandwalker wants to merge 2 commits intozsh-users:masterfrom
rolandwalker wants to merge 2 commits intozsh-users:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #777 another proposal is
ZSH_HIGHLIGHT_STYLES[cursor-containing-brackets], a dynamic style likecursor-matchingbracket, which changes with the context of the cursor.I left it unstyled by default in the PR. If enabled as
fg=red, with other bracket highlighting turned off, it works like this, revealing whichever balanced brackets currently contain the point:This PR currently includes the commit in #777, but I can rebase that problem away later.
No tests yet, just starting a discussion. I personally find this highlighting extremely valuable. Multiple levels could also be highlighted, like
bracket-level-N.