Add a missing "$" on a variable usage#908
Open
CharlesGueunet wants to merge 1 commit intozsh-users:masterfrom
Open
Add a missing "$" on a variable usage#908CharlesGueunet wants to merge 1 commit intozsh-users:masterfrom
CharlesGueunet wants to merge 1 commit intozsh-users:masterfrom
Conversation
Author
|
@danielshahaf please review |
| _zsh_highlight_main_highlighter_highlight_list $(( start_pos + i - 1 )) S $has_end $arg[i,-1] | ||
| ret=$? | ||
| (( i += REPLY )) | ||
| (( i += $REPLY )) |
Member
There was a problem hiding this comment.
Thanks for the patch. Unfortunately, it's not a complete fix.
Arithmetic expressions are parsed for substitutions and then, in a second pass, evaluate identifiers into their values. Thus, the incumbent code is correct, and even idiomatic (consider foo=2+2; echo $((foo*2)) $(($foo*2))), and conversely, the patch would seem to merely paper over the issue.
I'm curious why it works, but we can discuss that back on the issue's ticket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #907