main: Add systemd run0 equivalent to sudo#958
Open
ColinKinloch wants to merge 1 commit intozsh-users:masterfrom
Open
main: Add systemd run0 equivalent to sudo#958ColinKinloch wants to merge 1 commit intozsh-users:masterfrom
ColinKinloch wants to merge 1 commit intozsh-users:masterfrom
Conversation
Member
|
Is the second value a list of single letter flags arguments?
The middle value is list of single-letter flags that don't take arguments. E.g., 'sudo -u foo' uses 'foo' as an argument to '-u', so sudo's "u" is before the first colon; but 'sudo -l foo' interprets 'foo' as a positional argument, hence sudo's '-l' is in the middle group.
Lines 35 through 337 were supposed to make this clear, but there's room for improvement.
|
51073a4 to
e5f9905
Compare
Author
|
That makes sense, thanks. |
Member
|
And `-h` which seems to be intentionally omitted.
I do see a -h in <https://man.archlinux.org/man/run0.1.en>.
Could you add a comment stating the run0 version referenced? That's helpful down the road when looking for what flags were added/changed (we can just go through the upstream changelog, or diff upstream's man page source between tags).
Other than that, LGTM, but I'll defer to others to do the actual merge.
|
Author
Ah, never mind. I was confused by the absence of I've added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suspect these changes are incorrect or incomplete.Is the second value a list of single letter flags arguments? Should it be
Cgprtu:AEHPSbilns:eKkVv?run0is a systemd 256 alternative tosudo.