Skip to content

fix: improve voice name parsing in _say completion #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: improve voice name parsing in _say completion #149

wants to merge 1 commit into from
+1 −1

Conversation

@LangLangBart
Copy link
Contributor

Previously, the language identifier (e.g., 'it_IT', 'ar_001', 'en-scotland',...)
was appended to some voices with double parentheses, causing a fallback to the
default voice instead of the selected one. For example:

say -v 'Shelley (Italian' would have completed as:
'Shelley (Italian (Italy)) it_IT'
instead of:
'Shelley (Italian (Italy))'

Output for say -v '?'

macOS 15.7.1 (Sequoia)

Albert              en_US    # Hello! My name is Albert.
Alice               it_IT    # Ciao! Mi chiamo Alice.
Alva                sv_SE    # Hej! Jag heter Alva.
Amélie              fr_CA    # Bonjour! Je m’appelle Amélie.
Amira               ms_MY    # Hi my name is Amira
Anna                de_DE    # Hallo! Ich heiße Anna.
Anna (Premium)      de_DE    # Hallo! Ich heiße Anna.
Ava (Premium)       en_US    # Hello! My name is Ava.
Bad News            en_US    # Hello! My name is Bad News.
Bahh                en_US    # Hello! My name is Bahh.
Bells               en_US    # Hello! My name is Bells.
Boing               en_US    # Hello! My name is Boing.
Bubbles             en_US    # Hello! My name is Bubbles.
Carmit              he_IL    # שלום, שמי כרמית.
Cellos              en_US    # Hello! My name is Cellos.
Damayanti           id_ID    # Halo! Nama saya Damayanti.
Daniel              en_GB    # Hello! My name is Daniel.
Daria               bg_BG    # Hello! My name is Daria.
Wobble              en_US    # Hello! My name is Wobble.
Eddy (German (Germany)) de_DE    # Hallo! Ich heiße Eddy.
Eddy (English (UK)) en_GB    # Hello! My name is Eddy.
Eddy (English (US)) en_US    # Hello! My name is Eddy.
Eddy (Spanish (Spain)) es_ES    # ¡Hola! Me llamo Eddy.
Eddy (Spanish (Mexico)) es_MX    # ¡Hola! Me llamo Eddy.
Eddy (Finnish (Finland)) fi_FI    # Hei! Nimeni on Eddy.
Eddy (French (Canada)) fr_CA    # Bonjour! Je m’appelle Eddy.
Eddy (French (France)) fr_FR    # Bonjour, je m’appelle Eddy.
Eddy (Italian (Italy)) it_IT    # Ciao! Mi chiamo Eddy.
Eddy (Japanese (Japan)) ja_JP    # こんにちは! 私の名前はEddyです。
Eddy (Korean (South Korea)) ko_KR    # 안녕하세요. 제 이름은 Eddy입니다.
Eddy (Portuguese (Brazil)) pt_BR    # Olá, meu nome é Eddy.
Eddy (Chinese (China mainland)) zh_CN    # 你好！我叫Eddy。
Eddy (Chinese (Taiwan)) zh_TW    # 你好，我叫Eddy。
Ellen               nl_BE    # Hallo! Mijn naam is Ellen.
Flo (German (Germany)) de_DE    # Hallo! Ich heiße Flo.
Flo (English (UK))  en_GB    # Hello! My name is Flo.
Flo (English (US))  en_US    # Hello! My name is Flo.
Flo (Spanish (Spain)) es_ES    # ¡Hola! Me llamo Flo.
Flo (Spanish (Mexico)) es_MX    # ¡Hola! Me llamo Flo.
Flo (Finnish (Finland)) fi_FI    # Hei! Nimeni on Flo.
Flo (French (Canada)) fr_CA    # Bonjour! Je m’appelle Flo.
Flo (French (France)) fr_FR    # Bonjour, je m’appelle Flo.
Flo (Italian (Italy)) it_IT    # Ciao! Mi chiamo Flo.
Flo (Japanese (Japan)) ja_JP    # こんにちは! 私の名前はFloです。
Flo (Korean (South Korea)) ko_KR    # 안녕하세요. 제 이름은 Flo입니다.
Flo (Portuguese (Brazil)) pt_BR    # Olá, meu nome é Flo.
Flo (Chinese (China mainland)) zh_CN    # 你好！我叫Flo。
Flo (Chinese (Taiwan)) zh_TW    # 你好，我叫Flo。
Fred                en_US    # Hello! My name is Fred.
Good News           en_US    # Hello! My name is Good News.
Grandma (German (Germany)) de_DE    # Hallo! Ich heiße Grandma.
Grandma (English (UK)) en_GB    # Hello! My name is Grandma.
Grandma (English (US)) en_US    # Hello! My name is Grandma.
Grandma (Spanish (Spain)) es_ES    # ¡Hola! Me llamo Grandma.
Grandma (Spanish (Mexico)) es_MX    # ¡Hola! Me llamo Grandma.
Grandma (Finnish (Finland)) fi_FI    # Hei! Nimeni on Grandma.
Grandma (French (Canada)) fr_CA    # Bonjour! Je m’appelle Grandma.
Grandma (French (France)) fr_FR    # Bonjour, je m’appelle Grandma.
Grandma (Italian (Italy)) it_IT    # Ciao! Mi chiamo Grandma.
Grandma (Japanese (Japan)) ja_JP    # こんにちは! 私の名前はGrandmaです。
Grandma (Korean (South Korea)) ko_KR    # 안녕하세요. 제 이름은 Grandma입니다.
Grandma (Portuguese (Brazil)) pt_BR    # Olá, meu nome é Grandma.
Grandma (Chinese (China mainland)) zh_CN    # 你好！我叫Grandma。
Grandma (Chinese (Taiwan)) zh_TW    # 你好，我叫Grandma。
Grandpa (German (Germany)) de_DE    # Hallo! Ich heiße Grandpa.
Grandpa (English (UK)) en_GB    # Hello! My name is Grandpa.
Grandpa (English (US)) en_US    # Hello! My name is Grandpa.
Grandpa (Spanish (Spain)) es_ES    # ¡Hola! Me llamo Grandpa.
Grandpa (Spanish (Mexico)) es_MX    # ¡Hola! Me llamo Grandpa.
Grandpa (Finnish (Finland)) fi_FI    # Hei! Nimeni on Grandpa.
Grandpa (French (Canada)) fr_CA    # Bonjour! Je m’appelle Grandpa.
Grandpa (French (France)) fr_FR    # Bonjour, je m’appelle Grandpa.
Grandpa (Italian (Italy)) it_IT    # Ciao! Mi chiamo Grandpa.
Grandpa (Japanese (Japan)) ja_JP    # こんにちは! 私の名前はGrandpaです。
Grandpa (Korean (South Korea)) ko_KR    # 안녕하세요. 제 이름은 Grandpa입니다.
Grandpa (Portuguese (Brazil)) pt_BR    # Olá, meu nome é Grandpa.
Grandpa (Chinese (China mainland)) zh_CN    # 你好！我叫Grandpa。
Grandpa (Chinese (Taiwan)) zh_TW    # 你好，我叫Grandpa。
Jester              en_US    # Hello! My name is Jester.
Ioana               ro_RO    # Salut! Numele meu este Ioana.
Jacques             fr_FR    # Bonjour, je m’appelle Jacques.
Joana               pt_PT    # Olá! Chamo‑me Joana.
Junior              en_US    # Hello! My name is Junior.
Kanya               th_TH    # สวัสดี! ฉันชื่อกันยา
Karen               en_AU    # Hi my name is Karen
Kathy               en_US    # Hello! My name is Kathy.
Kyoko               ja_JP    # こんにちは! 私の名前はKyokoです。
Lana                hr_HR    # Bok, zovem se Lana.
Laura               sk_SK    # Ahoj, volám sa Laura.
Lekha               hi_IN    # नमस्ते, मेरा नाम लेखा है।
Lesya               uk_UA    # Привіт! Мене звуть Леся.
Linh                vi_VN    # Xin chào! Tên tôi là Linh.
Luciana             pt_BR    # Olá, meu nome é Luciana.
Majed               ar_001   # مرحبًا! اسمي ماجد.
Tünde               hu_HU    # Üdvözlöm! A nevem Tünde.
Meijia              zh_TW    # 你好，我叫美佳。
Melina              el_GR    # Χαίρετε! Το όνομά μου είναι «Μελίνα».
Milena              ru_RU    # Здравствуйте! Меня зовут Милена.
Moira               en_IE    # Hello! My name is Moira.
Mónica              es_ES    # ¡Hola! Me llamo Mónica.
Montse              ca_ES    # Hola! Em dic Montse.
Nora                nb_NO    # Hei! Jeg heter Nora.
Organ               en_US    # Hello! My name is Organ.
Paulina             es_MX    # ¡Hola! Me llamo Paulina.
Superstar           en_US    # Hello! My name is Superstar.
Ralph               en_US    # Hello! My name is Ralph.
Reed (German (Germany)) de_DE    # Hallo! Ich heiße Reed.
Reed (English (UK)) en_GB    # Hello! My name is Reed.
Reed (English (US)) en_US    # Hello! My name is Reed.
Reed (Spanish (Spain)) es_ES    # ¡Hola! Me llamo Reed.
Reed (Spanish (Mexico)) es_MX    # ¡Hola! Me llamo Reed.
Reed (Finnish (Finland)) fi_FI    # Hei! Nimeni on Reed.
Reed (French (Canada)) fr_CA    # Bonjour! Je m’appelle Reed.
Reed (Italian (Italy)) it_IT    # Ciao! Mi chiamo Reed.
Reed (Japanese (Japan)) ja_JP    # こんにちは! 私の名前はReedです。
Reed (Korean (South Korea)) ko_KR    # 안녕하세요. 제 이름은 Reed입니다.
Reed (Portuguese (Brazil)) pt_BR    # Olá, meu nome é Reed.
Reed (Chinese (China mainland)) zh_CN    # 你好！我叫Reed。
Reed (Chinese (Taiwan)) zh_TW    # 你好，我叫Reed。
Rishi               en_IN    # Hello! My name is Rishi.
Rocko (German (Germany)) de_DE    # Hallo! Ich heiße Rocko.
Rocko (English (UK)) en_GB    # Hello! My name is Rocko.
Rocko (English (US)) en_US    # Hello! My name is Rocko.
Rocko (Spanish (Spain)) es_ES    # ¡Hola! Me llamo Rocko.
Rocko (Spanish (Mexico)) es_MX    # ¡Hola! Me llamo Rocko.
Rocko (Finnish (Finland)) fi_FI    # Hei! Nimeni on Rocko.
Rocko (French (Canada)) fr_CA    # Bonjour! Je m’appelle Rocko.
Rocko (French (France)) fr_FR    # Bonjour, je m’appelle Rocko.
Rocko (Italian (Italy)) it_IT    # Ciao! Mi chiamo Rocko.
Rocko (Japanese (Japan)) ja_JP    # こんにちは! 私の名前はRockoです。
Rocko (Korean (South Korea)) ko_KR    # 안녕하세요. 제 이름은 Rocko입니다.
Rocko (Portuguese (Brazil)) pt_BR    # Olá, meu nome é Rocko.
Rocko (Chinese (China mainland)) zh_CN    # 你好！我叫Rocko。
Rocko (Chinese (Taiwan)) zh_TW    # 你好，我叫Rocko。
Samantha            en_US    # Hello! My name is Samantha.
Samantha (Enhanced) en_US    # Hello! My name is Samantha.
Sandy (German (Germany)) de_DE    # Hallo! Ich heiße Sandy.
Sandy (English (UK)) en_GB    # Hello! My name is Sandy.
Sandy (English (US)) en_US    # Hello! My name is Sandy.
Sandy (Spanish (Spain)) es_ES    # ¡Hola! Me llamo Sandy.
Sandy (Spanish (Mexico)) es_MX    # ¡Hola! Me llamo Sandy.
Sandy (Finnish (Finland)) fi_FI    # Hei! Nimeni on Sandy.
Sandy (French (Canada)) fr_CA    # Bonjour! Je m’appelle Sandy.
Sandy (French (France)) fr_FR    # Bonjour, je m’appelle Sandy.
Sandy (Italian (Italy)) it_IT    # Ciao! Mi chiamo Sandy.
Sandy (Japanese (Japan)) ja_JP    # こんにちは! 私の名前はSandyです。
Sandy (Korean (South Korea)) ko_KR    # 안녕하세요. 제 이름은 Sandy입니다.
Sandy (Portuguese (Brazil)) pt_BR    # Olá, meu nome é Sandy.
Sandy (Chinese (China mainland)) zh_CN    # 你好！我叫Sandy。
Sandy (Chinese (Taiwan)) zh_TW    # 你好，我叫Sandy。
Sara                da_DK    # Hej! Jeg hedder Sara.
Satu                fi_FI    # Hei! Nimeni on Satu.
Shelley (German (Germany)) de_DE    # Hallo! Ich heiße Shelley.
Shelley (English (UK)) en_GB    # Hello! My name is Shelley.
Shelley (English (US)) en_US    # Hello! My name is Shelley.
Shelley (Spanish (Spain)) es_ES    # ¡Hola! Me llamo Shelley.
Shelley (Spanish (Mexico)) es_MX    # ¡Hola! Me llamo Shelley.
Shelley (Finnish (Finland)) fi_FI    # Hei! Nimeni on Shelley.
Shelley (French (Canada)) fr_CA    # Bonjour! Je m’appelle Shelley.
Shelley (French (France)) fr_FR    # Bonjour, je m’appelle Shelley.
Shelley (Italian (Italy)) it_IT    # Ciao! Mi chiamo Shelley.
Shelley (Japanese (Japan)) ja_JP    # こんにちは! 私の名前はShelleyです。
Shelley (Korean (South Korea)) ko_KR    # 안녕하세요. 제 이름은 Shelley입니다.
Shelley (Portuguese (Brazil)) pt_BR    # Olá, meu nome é Shelley.
Shelley (Chinese (China mainland)) zh_CN    # 你好！我叫Shelley。
Shelley (Chinese (Taiwan)) zh_TW    # 你好，我叫Shelley。
Sinji               zh_HK    # 你好！我叫善怡。
Tessa               en_ZA    # Hello! My name is Tessa.
Thomas              fr_FR    # Bonjour, je m’appelle Thomas.
Tina                sl_SI    # Živijo, ime mi je Tina.
Tingting            zh_CN    # 你好！我叫婷婷。
Trinoids            en_US    # Hello! My name is Trinoids.
Vani                ta_IN    # Hello! My name is Vani.
Whisper             en_US    # Hello! My name is Whisper.
Xander              nl_NL    # Hallo! Mijn naam is Xander.
Yelda               tr_TR    # Merhaba, benim adım Yelda.
Yuna                ko_KR    # 안녕하세요. 제 이름은 유나입니다.
Zarvox              en_US    # Hello! My name is Zarvox.
Zoe (Premium)       en_US    # Hello! My name is Zoe.
Zosia               pl_PL    # Hi my name is Zosia
Zuzana              cs_CZ    # Hi my name is Zuzana

macOS 10.15.7 (Catalina)

Alex                en_US    # Most people recognize me by my voice.
Alice               it_IT    # Salve, mi chiamo Alice e sono una voce italiana.
Alva                sv_SE    # Hej, jag heter Alva. Jag är en svensk röst.
Amelie              fr_CA    # Bonjour, je m’appelle Amelie. Je suis une voix canadienne.
Anna                de_DE    # Hallo, ich heiße Anna und ich bin eine deutsche Stimme.
Carmit              he_IL    # שלום. קוראים לי כרמית, ואני קול בשפה העברית.
Damayanti           id_ID    # Halo, nama saya Damayanti. Saya berbahasa Indonesia.
Daniel              en_GB    # Hello, my name is Daniel. I am a British-English voice.
Diego               es_AR    # Hola, me llamo Diego y soy una voz española.
Ellen               nl_BE    # Hallo, mijn naam is Ellen. Ik ben een Belgische stem.
Fiona               en-scotland # Hello, my name is Fiona. I am a Scottish-English voice.
Fred                en_US    # I sure like being inside this fancy computer
Ioana               ro_RO    # Bună, mă cheamă Ioana . Sunt o voce românească.
Joana               pt_PT    # Olá, chamo-me Joana e dou voz ao português falado em Portugal.
Jorge               es_ES    # Hola, me llamo Jorge y soy una voz española.
Juan                es_MX    # Hola, me llamo Juan y soy una voz mexicana.
Kanya               th_TH    # สวัสดีค่ะ ดิฉันชื่อKanya
Karen               en_AU    # Hello, my name is Karen. I am an Australian-English voice.
Kyoko               ja_JP    # こんにちは、私の名前はKyokoです。日本語の音声をお届けします。
Laura               sk_SK    # Ahoj. Volám sa Laura . Som hlas v slovenskom jazyku.
Lekha               hi_IN    # नमस्कार, मेरा नाम लेखा है. मैं हिन्दी में बोलने वाली आवाज़ हूँ.
Luca                it_IT    # Salve, mi chiamo Luca e sono una voce italiana.
Luciana             pt_BR    # Olá, o meu nome é Luciana e a minha voz corresponde ao português que é falado no Brasil
Maged               ar_SA    # مرحبًا اسمي Maged. أنا عربي من السعودية.
Mariska             hu_HU    # Üdvözlöm! Mariska vagyok. Én vagyok a magyar hang.
Mei-Jia             zh_TW    # 您好，我叫美佳。我說國語。
Melina              el_GR    # Γεια σας, ονομάζομαι Melina. Είμαι μια ελληνική φωνή.
Milena              ru_RU    # Здравствуйте, меня зовут Milena. Я – русский голос системы.
Moira               en_IE    # Hello, my name is Moira. I am an Irish-English voice.
Monica              es_ES    # Hola, me llamo Monica y soy una voz española.
Nora                nb_NO    # Hei, jeg heter Nora. Jeg er en norsk stemme.
Paulina             es_MX    # Hola, me llamo Paulina y soy una voz mexicana.
Rishi               en_IN    # Hello, my name is Rishi. I am an Indian-English voice.
Samantha            en_US    # Hello, my name is Samantha. I am an American-English voice.
Sara                da_DK    # Hej, jeg hedder Sara. Jeg er en dansk stemme.
Satu                fi_FI    # Hei, minun nimeni on Satu. Olen suomalainen ääni.
Sin-ji              zh_HK    # 您好，我叫 Sin-ji。我講廣東話。
Tessa               en_ZA    # Hello, my name is Tessa. I am a South African-English voice.
Thomas              fr_FR    # Bonjour, je m’appelle Thomas. Je suis une voix française.
Ting-Ting           zh_CN    # 您好，我叫Ting-Ting。我讲中文普通话。
Veena               en_IN    # Hello, my name is Veena. I am an Indian-English voice.
Victoria            en_US    # Isn't it nice to have a computer that will talk to you?
Xander              nl_NL    # Hallo, mijn naam is Xander. Ik ben een Nederlandse stem.
Yelda               tr_TR    # Merhaba, benim adım Yelda. Ben Türkçe bir sesim.
Yuna                ko_KR    # 안녕하세요. 제 이름은 Yuna입니다. 저는 한국어 음성입니다.
Yuri                ru_RU    # Здравствуйте, меня зовут Yuri. Я – русский голос системы.
Zosia               pl_PL    # Witaj. Mam na imię Zosia, jestem głosem kobiecym dla języka polskiego.
Zuzana              cs_CZ    # Dobrý den, jmenuji se Zuzana. Jsem český hlas.

@LangLangBart
fix: improve voice name parsing in _say completion
e96f922 
Previously, the language identifier (e.g., 'it_IT', 'ar_001', 'en-scotland',...)
was appended to some voices with double parentheses, causing a fallback to the
default voice instead of the selected one. For example:

`say -v 'Shelley (Italian<TAB>' would have completed as:
'Shelley (Italian (Italy)) it_IT'
instead of:
'Shelley (Italian (Italy))'
hubot pushed a commit that referenced this pull request Oct 31, 2025
@LangLangBart
github #149: improve voice name parsing in say completion
7bf0500
@LangLangBart
Copy link
Contributor Author

7bf0500

@LangLangBart LangLangBart deleted the say_darwin branch October 31, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@LangLangBart