fix conversion of refetch variable with None custom scalar #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsnobip
force-pushed
the
refetch-variable-custom-scalars
branch
2 times, most recently
from
640ba55 to
0b9ec14
Compare
tsnobip
force-pushed
the
refetch-variable-custom-scalars
branch
3 times, most recently
from
e6580f6 to
592be0b
Compare
tsnobip
force-pushed
the
refetch-variable-custom-scalars
branch
from
592be0b to
aa0e5da
Compare
tsnobip
changed the title
tsnobip
commented
Jul 10, 2025
Comment on lines
+82
to
+87
| if (currentObj[key] && currentObj[key].BS_PRIVATE_NESTED_SOME_NONE >= 0) { | ||
| newObj = getNewObj(newObj, currentObj); | ||
| newObj[key] = currentObj[key]; | ||
| continue; | ||
| } | ||
|
|
Owner
There was a problem hiding this comment.
Fantastic! Great find. Would you add a comment in the code about what this is?
Owner
|
Amazing! Would you add a changelog as well? |
Collaborator
Author
|
Woops I forgot about that! |
Collaborator
Author
|
@zth done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.