Draggable and inline titlebar for MacOS electron app#339
Open
SilverMarcs wants to merge 2 commits intoztjhz:mainfrom
Open
Draggable and inline titlebar for MacOS electron app#339SilverMarcs wants to merge 2 commits intoztjhz:mainfrom
SilverMarcs wants to merge 2 commits intoztjhz:mainfrom
Conversation
Contributor
|
Works great!
The way it is right now in the main repo is a bit confusing since mouse hover on each of the option opens the same window anyway. I wouldn't add another redundant trigger that further confuses users. (Even the way it is now should be reworked imo but that's another issue) |
Author
I felt this too. And I suppose yeah, the edit icon doesn't add much to the design. If the headerbar isn't clickable, hovering on the individual items should already hint the user that they are clickable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let me know if the Edit icon on headerbar should be removed. The initial idea was to let MacOS users have a button that does the same thing as clicking the entire top area on other systems (open modal menu).
How it looks: