Pass different parameters to mktemp on OSX#4
Conversation
|
Fixes #3 |
|
Any updates on getting this merged, @ztombol? |
| local path | ||
| path="$(mktemp --directory --tmpdir="$BATS_TMPDIR" -- "$template" 2>&1)" | ||
|
|
||
| if [ "$(uname -s)" == "Darwin" ]; then |
There was a problem hiding this comment.
Wouldn't you want to detect which mktemp rather than the OS?
if mktemp --version >/dev/null 2>&1 ; then
echo Using GNU mktemp
else
echo Using BSD mktemp
fiThere was a problem hiding this comment.
Feel free to add my remote and implement that change, I currently don't have bats set up on my machine, and given that this PR is been ignored for about 3 months now, I don't think it's worth the effort to try to improve it.
There was a problem hiding this comment.
I've verified this works as expected on my mac.
There was a problem hiding this comment.
Given mac doesn't work at all, could we land this rather than bike shed it?
|
@mlopes since it seems this repo is not longer maintained, I started my own fork and working on some changes there: https://github.com/peshay/bats-file/tree/patch-1 |
No description provided.