Enable maxLength on credential entry rows for Adw >= 1.6#75
Merged
Conversation
Add isAdwVersionAtLeast() utility and use it to conditionally set maxLength on EntryRow/PasswordEntryRow, working around a java-gi crash present in earlier libadwaita versions. Software-side validation continues to enforce limits on older runtimes.
Owner
Author
|
Refs: jwharm/java-gi#335. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isAdwVersionAtLeast(major, minor, micro)utility toAppUtils.ktfor runtime libadwaita version checksADW_MAX_LENGTH_MIN_MAJOR_VERSION/ADW_MAX_LENGTH_MIN_MINOR_VERSIONconstants (1.6) toAppConstants.ktmaxLengthonEntryRow/PasswordEntryRowinAddCredentialDialogonly when Adw ≥ 1.6, working around a java-gi crash in earlier versionsApp.ktto use the new helperSoftware-side validation in
validateInput()continues to enforce length limits on runtimes older than 1.6.Test plan
./gradlew detektpasses cleanly