Skip to content

email_server: Open port 25 and document EMAIL_GATEWAY_PATTERN. #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexmv
Copy link
Contributor

@alexmv alexmv commented Jul 1, 2025

Requires zulip/zulip#35081

Fixes:

How did you test this PR?

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@timabbott
Copy link
Member

Looks good, I wonder if we there's a good place to also document this in the README.md, with an anchor so it can be linked from the main documentation.

@timabbott
Copy link
Member

timabbott commented Jul 2, 2025

Do we need to wait for 11.0 to be released with zulip/zulip#35081 (and more importantly, the introduction of the new system)?

@alexmv alexmv force-pushed the docker-localmail branch from 63b494b to 1217509 Compare July 25, 2025 22:19
@alexmv
Copy link
Contributor Author

alexmv commented Jul 25, 2025

I've updated the Helm charts. I don't think there's any major downside to merging this before 11.0, except that it'll expose a port 25 with nothing listening on it, and the comments will imply something works that won't yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants