helm: Support pre-existing external services instead of subcharts.#609
Open
alexmv wants to merge 1 commit intozulip:mainfrom
Open
helm: Support pre-existing external services instead of subcharts.#609alexmv wants to merge 1 commit intozulip:mainfrom
alexmv wants to merge 1 commit intozulip:mainfrom
Conversation
7e1e7a9 to
a009fac
Compare
Add the ability to use external (pre-existing) PostgreSQL, RabbitMQ, Memcached, and Redis servers instead of always deploying Bitnami subcharts. Each service gets a `<service>.enabled` condition in Chart.yaml and a corresponding `external<Service>` values section for configuring the external connection details. When `<service>.enabled` is set to false, the subchart is not deployed and the Zulip container is configured to connect to the external host specified in the `external<Service>` values. The default behavior is unchanged — all subcharts deploy by default with `enabled: true`. Fixes: zulip#360. Co-authored-by: Claude <noreply@anthropic.com>
a009fac to
9aca31f
Compare
Contributor
|
I do like this suggestion, and also the way we want to deploy Zulip (and any other application). I haven't tested the merge request itself - but the solution - thumbs up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to use external (pre-existing) PostgreSQL, RabbitMQ, Memcached, and Redis servers instead of always deploying Bitnami subcharts. Each service gets a
<service>.enabledcondition in Chart.yaml and a correspondingexternal<Service>values section for configuring the external connection details.When
<service>.enabledis set to false, the subchart is not deployed and the Zulip container is configured to connect to the external host specified in theexternal<Service>values.The default behavior is unchanged — all subcharts deploy by default with
enabled: true.Fixes: #360.
Fixes:
How did you test this PR?
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: