Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While completing an install on my cluster I had the need to use annotations on the service. The helm chart was missing that aspect so I added it.
Fixes: Allows for adding annotations to services (no pre-existing issue).
Using this config snippet in the
values-local.yaml:And then running
helm template --create-namespace --namespace zulip -f ./values-local.yaml zulip . > templated.yamlresults in this output (rest of yaml omitted for brevity):
Running with this config (without annotations):
and running the same command, results in this service yaml:
I am using this fork in a running installation using annotations as well.
Edits to my comments, especially in the example are welcome! This is a fairly straightforward fix and I tried to mirror how annotations work for the ingress.
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: