Fix unnecessary image rotation in PhotoSendActivity.

When a picture is clicked and sent directly (without a crop or edit), it
gets rotated by 90 as most phone cameras are landscape. To solve this,
it'd be better to use the displayed image and save it in the current
photo path before sending.

Author: Sam1301

app/src/main/java/com/zulip/android/activities/PhotoSendActivity.java

@@ -115,24 +115,27 @@ public void onClick(View view) {
         sendPhoto.setOnClickListener(new View.OnClickListener() {
             @Override
             public void onClick(View view) {
-                if (mIsCropped) {
-                    Bitmap bitmap;
-                    Drawable drawable = mImageView.getDrawable();
-                    if (drawable instanceof GlideBitmapDrawable) {
-                        // if imageview has drawable of type GlideBitmapDrawable
-                        bitmap = ((GlideBitmapDrawable) mImageView.getDrawable().getCurrent())
-                                .getBitmap();
-
-                    } else {
-                        // if imageView stores cropped image drawable which is of type drawable
-                        bitmap = ((BitmapDrawable) mImageView.getDrawable()).getBitmap();
-                    }
+                Bitmap bitmap;
+                Drawable drawable = mImageView.getDrawable();
+                if (drawable instanceof GlideBitmapDrawable) {
+                    // if imageview has drawable of type GlideBitmapDrawable
+                    bitmap = ((GlideBitmapDrawable) mImageView.getDrawable().getCurrent())
+                            .getBitmap();
 
-                    // if image was cropped, delete old file
-                    // and store new bitmap on that location
-                    mPhotoPath = PhotoHelper.saveBitmapAsFile(mPhotoPath, bitmap);
+                } else {
+                    // if imageView stores cropped image drawable which is of type drawable
+                    bitmap = ((BitmapDrawable) mImageView.getDrawable()).getBitmap();
                 }
 
+                /* Most phone cameras are landscape, meaning if you take the photo in portrait,
+                   the resulting photos will be rotated 90 degrees. Hence used the displayed image
+                   with correct orientation and saved that in the current photo path.
+                */
+
+                // delete old file and store new bitmap on that location
+                // used the displayed image and saved it in the mPhotoPath
+                mPhotoPath = PhotoHelper.saveBitmapAsFile(mPhotoPath, bitmap);
+
                 // add the file path of cropped image
                 sendIntent.putExtra(Intent.EXTRA_TEXT, mPhotoPath);
                 startActivity(sendIntent);