Unify references to emulator

Author: niftynei

app/src/main/java/com/zulip/android/BuildHelper.java

@@ -0,0 +1,14 @@
+package com.zulip.android;
+
+import android.os.Build;
+
+public class BuildHelper {
+
+    public static boolean shouldLogToCrashlytics() {
+        return !isEmulator() && !BuildConfig.DEBUG;
+    }
+
+    public static boolean isEmulator() {
+        return Build.HARDWARE.contains("goldfish");
+    }
+}

app/src/main/java/com/zulip/android/ZLog.java

@@ -1,13 +1,11 @@
 package com.zulip.android;
 
-import android.os.Build;
-
 import com.crashlytics.android.Crashlytics;
 
 public class ZLog {
 
     public static void logException(Throwable e) {
-        if (Build.HARDWARE.contains("goldfish")) {
+        if (BuildHelper.shouldLogToCrashlytics()) {
             e.printStackTrace();
         } else {
             Crashlytics.logException(e);

app/src/main/java/com/zulip/android/ZulipApp.java

@@ -10,7 +10,6 @@
 import android.content.SharedPreferences.Editor;
 import android.content.pm.PackageInfo;
 import android.content.pm.PackageManager.NameNotFoundException;
-import android.os.Build;
 import android.os.Handler;
 import android.util.Log;
 
@@ -72,10 +71,7 @@ public void onCreate() {
         lastEventId = settings.getInt("lastEventId", -1);
         pointer = settings.getInt("pointer", -1);
 
-
-        if (Build.HARDWARE.contains("goldfish") || BuildConfig.DEBUG) { // dont load crashlytics for debug builds
-            Log.i("hardware", "running in emulator");
-        } else {
+        if (BuildHelper.shouldLogToCrashlytics()) {
             Crashlytics.start(this);
         }