Tray: unread messages icon fix for linux

[Aitchessbee]

Fixes #1364

You have tested this PR on:

• Windows
• Linux/Ubuntu
• macOS

[Aitchessbee]

So the issue was in the window.devicePixelRatio used in renderCanvas code (that is only being run for linux). window.devicePixelRatio takes the value of the scaling factor set on your linux PC, and if it's anything other than 1, the icon breaks... With the scaling factor set to 1 the icon stays the same size irrespective of the scaling factor, which also matches the other tray icons that I had (cloudinary and slack)...

Old -

New -

[alya]

Thanks for the fix! Could you please update your commit message to match the commit style guidelines?

Also, please add before/after screenshots to the PR description.

[Aitchessbee]

Done! Let me know if there are any other changes...

[mkaminsky]

I've had this problem for a while, under both X11 and Wayland, using a 4K screen with my display scaled to 200%.

I wanted to confirm that the fix here works for me--thanks @Aitchessbee

Would love to see this PR included in the next release. Thanks for all the great work on Zulip!

[alya]

@andersk are you up for reviewing this proposed one-line change?

[mkaminsky]

I just started using the v5.12.0 release that came out yesterday. It doesn't look like this fix made it in--the unread icon is broken.

I had rebuilt the previous release with the patch here and have been running it since August. It's working very consistently. I can do that again, but I wanted to ask if there's any chance to sneak this fix in a new patch release?

Thanks!

[shubham-padia]

@timabbott I think this should be fine to merge for now, there is a risk that the logo might look low res in high pixel density devices, but that is a much better option than the current situation of the logo being distorted.

We might want to change the commit message to shift the Fixes #issue-no to a new line while merging.

[timabbott]

@shubham-padia looking at this more closely, I think we should be deleting that pixelRatio field, as it no longer does anything (the config format at least looks local to that file). @shubham-padia can you just open a new PR making that change and with a nicer commit message? Then we can close this out.

Thanks everyone for debugging this!