settings: Always show the sidebar in case of settings page.#1431
Open
shubham-padia wants to merge 1 commit intozulip:mainfrom
Open
settings: Always show the sidebar in case of settings page.#1431shubham-padia wants to merge 1 commit intozulip:mainfrom
shubham-padia wants to merge 1 commit intozulip:mainfrom
Conversation
timabbott
reviewed
Jun 19, 2025
timabbott
reviewed
Jun 19, 2025
75e2279 to
d15c50e
Compare
timabbott
reviewed
Jun 20, 2025
Member
|
I think this should not be hard to finish, but we do need to resolve my correctness concerns above before it's ready for Anders to review. |
Fixes zulip#1077. Users were getting stuck in the settings page, unable to click on an organisation tab to go back. Enabling the sidebar for settings page in all cases will help ensure that the users can navigate back when needed.
d15c50e to
6466e5f
Compare
Member
|
This version looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1077.
Users were getting stuck in the settings page, unable to click on an organisation tab to go back. Enabling the sidebar for settings page in all cases will help ensure that the users can navigate back when needed.
Screenshots and screen captures:
Platforms this PR was tested on:
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: