tabs: Add spacing between the tab icon and the server tooltip.#1465
tabs: Add spacing between the tab icon and the server tooltip.#1465shubham-padia wants to merge 1 commit intozulip:mainfrom
Conversation
|
I discussed this change with @andersk and he pointed out that this is desktop app UI and should not be entirely on the user-controlled side of the Line of Death (See e.g., https://emilymstark.com/2022/12/18/death-to-the-line-of-death.html), which this PR moves it to be. In practice what I think that means is we should have the arrow move left instead, so the arrow overlaps into the avatar box, and have the arrow have a different/shape color where it will have suitable contrast with the UI elements there. |
|
Got it, in this case the original issue would not be valid and we should just close that?
This seems like a different issue. I'm not sure of the priority here, but my assumption is that it's not high priority. |
|
I think @timabbott was suggesting maybe moving this tooltip further left? Do the other tooltips actually mentioned in the issue actually need to be pulled left to match this one? |
|
Not sure any of this is important. |
Fixes #1087.
Screenshots and screen captures:

Before:
After:

Platforms this PR was tested on:
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: