permissions: Allow fullscreen video requests on macOS#1469
Open
shubham-padia wants to merge 1 commit intozulip:mainfrom
Open
permissions: Allow fullscreen video requests on macOS#1469shubham-padia wants to merge 1 commit intozulip:mainfrom
shubham-padia wants to merge 1 commit intozulip:mainfrom
Conversation
On macOS, videos embedded in Zulip Desktop could not enter fullscreen
mode because the app's permission handler did not explicitly grant
fullscreen permissions.
This commit updates the `ipcRenderer.on("permission-request")` handler
to include fullscreen, in addition to existing permissions such as
notifications. With this change, video players (e.g., YouTube and
Zulip-embedded media) can properly request fullscreen.
Tested on macOS to confirm fullscreen now works, and on Windows/Linux
to ensure no regressions.
Fixes zulip#1409.
7 tasks
Collaborator
|
@andersk Are you up for reviewing this one? |
Member
|
This does not work with YouTube videos ( On Linux (both Xorg and Wayland), it does allow uploaded videos to be full-screened, but when you do this, the application menu bar disappears. This is almost certainly an upstream Electron bug that needs to be investigated. |
Collaborator
Can you please elaborate ? like YouTube Embeddings are working in my system, i've also uploaded a screen recorded video as a proof in the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS, videos embedded in Zulip Desktop could not enter fullscreen mode because the app's permission handler did not explicitly grant fullscreen permissions.
This commit updates the
ipcRenderer.on("permission-request")handler to include fullscreen, in addition to existing permissions such as notifications. With this change, video players (e.g., YouTube and Zulip-embedded media) can properly request fullscreen.Tested on macOS to confirm fullscreen now works, and on Windows/Linux to ensure no regressions.
Fixes #1409.
Supersedes #1456
Screenshots and screen captures:
Platforms this PR was tested on:
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: