Improve reconnect error page UI and network handling#1488
Open
AaineeSinha wants to merge 1 commit intozulip:mainfrom
Open
Improve reconnect error page UI and network handling#1488AaineeSinha wants to merge 1 commit intozulip:mainfrom
AaineeSinha wants to merge 1 commit intozulip:mainfrom
Conversation
Collaborator
|
Thanks! What does the UI you're proposing to replace look like now? Is there an issue this is solving? In general, design changes are made with community discussion. |
Collaborator
Author
Collaborator
|
I mean what does the current UI look like, not your proposed new UI. |
Collaborator
|
What's going on with your images? Are you taking pictures of your computer? |
Collaborator
Author
Collaborator
|
OK, please get that figured out, so that your work can be reviewed. |
Collaborator
Author
Collaborator
|
Is this PR solving an open issue? If so, please link to it from the PR description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR provides a comprehensive update to the network error handling and app initialization flow. It replaces the default system/blank error page with a custom Zulip-branded “Unable to connect” UI and resolves the brief white screen flash that occurred during application startup.
Key improvements
Custom error UI
network.htmlStartup optimization
app/main/index.ts)Logic recovery and stabilization
logger-util.ts,messages.ts,typed-ipc.ts)Build integrity
package.jsonandpnpm-lock.yamlwith required dependencies (including Zod and Electron Remote)Screenshots and screen captures
Zulip.error.1.mp4
Platforms this PR was tested on
Self-review checklist
Summary of changes
app/main/index.tsandrequest.tsto improve startup rendering and failure handlingnetwork.htmland updated related CSS/TS