Improve reconnect error page layout for resizing#1499
Closed
Paperyduke6 wants to merge 5 commits intozulip:mainfrom
Closed
Improve reconnect error page layout for resizing#1499Paperyduke6 wants to merge 5 commits intozulip:mainfrom
Paperyduke6 wants to merge 5 commits intozulip:mainfrom
Conversation
…for all screen sizes and have a small animation
Member
|
@Paperyduke6 You've referenced #862 in your pull request description, but you have not referenced them in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage. Please run An example of a correctly-formatted commit: In addition, please make sure your commit structure and messages follow all guidelines. |
Author
|
This repo had package-lock.json as well which should have been ignored. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #862 — Improves the reconnect error page layout, responsiveness,
and visual polish while staying close to the original design language.
Problem
The existing network error page had some layout issues:
margin: 100px 200pxon the content container caused the pageto collapse or overflow on smaller window sizes
margin-left: 116pxon the Settingsbutton, which was fragile and broke on non-default layouts
#buttonscontainer usedfloat: leftfor layout, which isoutdated and conflicts with modern box model expectations
windows
Changes Made
HTML (
network.html)#error-textdiv to create a unified text block that alignsdirectly under the image
CSS (
network.css)margin: 100px 200pxwithmax-width: 520pxandmargin: 60px autoso the card centres itself at any window widthalign-items: centerto#contentso image and text blockstack centrally on the vertical axis
#error-text { width: 100% }to keep text flush within thecard without breaking left-alignment of the copy
float: leftand hardcodedmargin-left: 116pxon buttonswith
display: flex; gap: 12pxon#buttons— cleaner, moremaintainable
max-width: 100%; width: 320px; display: block; margin: 0 autoto the image so it scales correctly and centres independently of the
container
border-radiusandbox-shadowto visually separate the error state from a blank white page
give the page a dynamic feel to it
transitionandtransformon.buttonhover/active statesfor more tactile button feedback
line-height: 1.8to#descriptionfor better readabilityof the bullet list
rgb(90 100 112)on subtitle and description tocreate visual hierarchy — title draws the eye first, explanation text
reads second
Testing
error page
states
ScreenCapture
Reconnect.page.new.layout.mp4