Mark as resolved/unresolved prep 2#1306

Merged

gnprice merged 19 commits intozulip:mainfrom

chrisbobbe:pr-action-sheet-test-refactors

Jan 28, 2025

Commits on Jan 27, 2025

action_sheet test: Make the app-bar topic-row finder more precise
chrisbobbe
committed
action_sheet test [nfc]: Make checkButtons helper for showTopicActionSheet
chrisbobbe
committed
action_sheet test [nfc]: Add new '{topic,message} action sheet' groups
chrisbobbe
committed
action_sheet test: Make some show-from-inbox setup optional in a `prepare`
chrisbobbe
committed
action_sheet test [nfc]: Parameterize a `prepare` by channel and topic
chrisbobbe
committed
action_sheet test [nfc]: Pull out `someMessage` variable
chrisbobbe
committed
action_sheet test [nfc]: Add zulipFeatureLevel param to a `prepare`
chrisbobbe
committed
action_sheet test [nfc]: Add subscription-related params to a `prepare`
chrisbobbe
committed
action_sheet test [nfc]: Add `visibilityPolicy` to a `prepare`
chrisbobbe
committed
action_sheet test: Use eg.otherUser for a sender in setupToTopicActionSheet
chrisbobbe
committed
action_sheet test [nfc]: Pull out a `prepare` function and reuse
chrisbobbe
committed
action_sheet test [nfc]: Simplify some setup by using someChannel
chrisbobbe
committed
action_sheet test [nfc]: Pull out showFromInbox helper
chrisbobbe
committed
action_sheet test [nfc]: Pull out showFromAppBar helper
chrisbobbe
committed
action_sheet test: Cut assumption of topic recipient header in topic narrow
chrisbobbe
committed
action_sheet test [nfc]: Pull out showFromRecipientHeader helper
chrisbobbe
committed
test [nfc]: Comment on where to find topic-action-sheet tests
chrisbobbe
committed
action_sheet test: Move some logic out of checkButtons helper
chrisbobbe
committed
action_sheet test [nfc]: Have showFromAppBar take `messages`, not `message`
chrisbobbe
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Mark as resolved/unresolved prep 2#1306

Mark as resolved/unresolved prep 2#1306
gnprice merged 19 commits intozulip:mainfrom
chrisbobbe:pr-action-sheet-test-refactors

Commits on Jan 27, 2025

action_sheet test: Make the app-bar topic-row finder more precise

action_sheet test [nfc]: Make checkButtons helper for showTopicActionSheet

action_sheet test [nfc]: Add new '{topic,message} action sheet' groups

action_sheet test: Make some show-from-inbox setup optional in a `prepare`

action_sheet test [nfc]: Parameterize a `prepare` by channel and topic

action_sheet test [nfc]: Pull out `someMessage` variable

action_sheet test [nfc]: Add zulipFeatureLevel param to a `prepare`

action_sheet test [nfc]: Add subscription-related params to a `prepare`

action_sheet test [nfc]: Add `visibilityPolicy` to a `prepare`

action_sheet test: Use eg.otherUser for a sender in setupToTopicActionSheet

action_sheet test [nfc]: Pull out a `prepare` function and reuse

action_sheet test [nfc]: Simplify some setup by using someChannel

action_sheet test [nfc]: Pull out showFromInbox helper

action_sheet test [nfc]: Pull out showFromAppBar helper

action_sheet test: Cut assumption of topic recipient header in topic narrow

action_sheet test [nfc]: Pull out showFromRecipientHeader helper

test [nfc]: Comment on where to find topic-action-sheet tests

action_sheet test: Move some logic out of checkButtons helper

action_sheet test [nfc]: Have showFromAppBar take `messages`, not `message`

Mark as resolved/unresolved prep 2#1306gnprice merged 19 commits intozulip:mainzulip/zulip-flutter:mainfrom chrisbobbe:pr-action-sheet-test-refactorschrisbobbe/zulip-flutter:pr-action-sheet-test-refactorsCopy head branch name to clipboard

Commits

Commits on Jan 27, 2025

Mark as resolved/unresolved prep 2#1306
gnprice merged 19 commits intozulip:mainfrom
chrisbobbe:pr-action-sheet-test-refactors