-
Notifications
You must be signed in to change notification settings - Fork 350
share: Support choosing an account, if there are multiple #1816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2f733cc to
33b20ce
Compare
|
Thanks for building this! I think my ideal version of this would have a slightly different UX:
I've pushed a rough draft of an approach like this, but it has some gaps:
If this approach sounds good, would you PTAL? Several of the commits are just cherry picks from #1802 which is close to merge. |
lib/widgets/button.dart is probably better as a home for this; would need some dartdoc/etc.
Just like BottomSheetEmptyContentPlaceholder has.
33b20ce to
e38794e
Compare
|
Pushed with a rebase past #1802. |
|
Thanks @chrisbobbe for those draft commits. I've sent a new revision as a separate PR (#1883) to preserve these draft commits. That PR addresses some of the points mentioned at #1816 (comment). Modulo the nullable currently selected account state, instead it selects the current account as the initial account, PTAL. |
Tests are TODO and will happen as part of #1787 in a follow-up PR.
Fixes: #1779