-
Notifications
You must be signed in to change notification settings - Fork 350
Channel link autocomplete #1902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sm-sayedi
wants to merge
16
commits into
zulip:main
Choose a base branch
from
sm-sayedi:124-channel-link-autocomplete
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
236c11c
api: Add InitialSnapshot.maxChannelNameLength
sm-sayedi 9c7c25f
realm: Add RealmStore.maxChannelNameLength
sm-sayedi 5ff30b8
api: Add ZulipStream.isRecentlyActive
sm-sayedi eb33934
api: Update ChannelDeleteEvent to match new API changes
sm-sayedi bdd47bf
autocomplete: Introduce `AutocompleteViewManager._autocompleteViews`
sm-sayedi 31273e3
store: Call AutocompleteViewManager.handleUserGroupRemove/UpdateEvent
sm-sayedi 0f6f88d
autocomplete [nfc]: Move _matchName up to AutocompleteQuery
sm-sayedi ef60f4a
autocomplete: Add view-model ChannelLinkAutocompleteView
sm-sayedi 0d30546
autocomplete test [nfc]: Use MarkedTextParse as the return type of pa…
sm-sayedi f6ba102
compose: Introduce PerAccountStore in ComposeController
sm-sayedi 1977e20
autocomplete: Identify when the user intends a channel link autocomplete
sm-sayedi 33d9b46
autocomplete [nfc]: Add a TODO(#1967) for ignoring starting "**" afte…
sm-sayedi c7651f2
autocomplete test: Make setupToComposeInput accept `channels` param
sm-sayedi 5fc6a99
internal_link [nfc]: Factor out constructing fragment in its own method
sm-sayedi 032713d
compose: Introduce `fallbackMarkdownLink` function
sm-sayedi d4e2458
channel: Finish channel link autocomplete for compose box
sm-sayedi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's link to #api design > stream deletion events @ 💬 in the commit message.
(Also a nit: the symptom is described in that discussion; it's noticeable but it's not as bad as crashing the app.)