Settings Page UI redesign #1918
Open
+224
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MdSaifAliMolla
force-pushed
the
settings-UI
branch
from
2638578 to
ad2a0e1
Compare
Member
|
Thanks. It looks like you have a couple of other PRs open already:
Let's start with feedback on those. After you've successfully revised those to be highly reviewable PRs (https://zulip.readthedocs.io/en/latest/contributing/reviewable-prs.html), then you'll be more prepared to come back and do the same with this one. |
MdSaifAliMolla
force-pushed
the
settings-UI
branch
from
ad2a0e1 to
6815c27
Compare
MdSaifAliMolla
force-pushed
the
settings-UI
branch
2 times, most recently
from
30a22a0 to
b601bd5
Compare
MdSaifAliMolla
force-pushed
the
settings-UI
branch
3 times, most recently
from
1136df7 to
3d15467
Compare
Added to maintain consistent style and reuse the components enhancing modularity.
MdSaifAliMolla
force-pushed
the
settings-UI
branch
from
3d15467 to
6f5f562
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1375