api: Add ZulipStream.topicsPolicy #1956
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
reviewed
Oct 30, 2025
Collaborator
chrisbobbe
left a comment
chrisbobbe
left a comment
There was a problem hiding this comment.
Thanks! Comments below.
Also, some commit-message nits:
api: Add ZulipStream.TopicsPolicy
Ingest String `topics_policy` field. The field can take be one of 4
possible values, inherit, allow_empty_topic, disable_empty_topic,
and empty_topic_only. Enum TopicsPolicy is created for these four
values.
Fixes: https://github.com/zulip/zulip-flutter/issues/1604
ZulipStream.TopicsPolicydoesn't refer to anything that exists; instead, sayZulipStream.topicsPolicy(referring to the field) orTopicsPolicy(referring to the enum).- The paragraph ("Ingest String…") just repeats what's already clear and expected in the diff; let's remove it, so there's less we need to read through.
- This work is a prerequisite for #1604 (making the data available to the app), but I'd like to keep #1604 open for the work of actually using the data in the compose-box UI code. So let's remove the "Fixes" line.
chungwwei
force-pushed
the
ingest-topics-policy
branch
2 times, most recently
from
7cffea4 to
17fca1c
Compare
chungwwei
changed the title
chungwwei
force-pushed
the
ingest-topics-policy
branch
from
17fca1c to
02b5b4d
Compare
Collaborator
|
I see you've pushed changes; please comment here when this is ready for another review. |
chungwwei
force-pushed
the
ingest-topics-policy
branch
from
02b5b4d to
22cdda8
Compare
Contributor
Author
|
Thanks for reviewing before! It's ready for another round. |
chrisbobbe
reviewed
Nov 4, 2025
Collaborator
chrisbobbe
left a comment
chrisbobbe
left a comment
There was a problem hiding this comment.
Thanks! Just one nit below.
lib/api/model/model.dart
Outdated
Comment on lines
784
to
786
| static TopicsPolicy fromRawString(String raw) => _byRawString[raw] ?? inherit; | ||
|
|
||
| static final _byRawString = _$TopicsPolicyEnumMap.map((key, value) => MapEntry(value, key)); |
Collaborator
There was a problem hiding this comment.
Let's call these fromApiValue and _byApiValue.
Collaborator
|
I've also removed the "Fixes:" line from the PR description, for the same reason I mentioned above in #1956 (review). |
chungwwei
force-pushed
the
ingest-topics-policy
branch
from
22cdda8 to
6639351
Compare
Enum TopicsPolicy is created for these four values: inherit, allow_empty_topic, disable_empty_topic, and empty_topic_only.
chungwwei
force-pushed
the
ingest-topics-policy
branch
from
6639351 to
afc7562
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ingest String
topics_policyfield. Will be used to hide the topic input in the general-chat-only channel.