RealmInputScreen [nfc]: Inline SmartUrlInput #5572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
force-pushed
the
pr-inline-smart-url-input
branch
from
1617e0d to
d7723c5
Compare
gnprice
reviewed
Dec 2, 2022
Member
gnprice
left a comment
gnprice
left a comment
There was a problem hiding this comment.
Thanks @chrisbobbe for this cleanup!
All looks good -- just one small further cleanup opportunity noted below. Please merge at will.
src/start/RealmInputScreen.js
Outdated
Comment on lines
90
to
92
| const handleRealmChange = useCallback(value => { | ||
| setRealmInputValue(value); | ||
| }, []); |
Member
There was a problem hiding this comment.
Can simplify this (in a followup commit) to just setRealmInputValue -- just refer to that directly instead of adding the name handleRealmChange.
…rnKey… This and the next several commits prepare to inline the definition of SmartUrlInput at its only caller.
chrisbobbe
force-pushed
the
pr-inline-smart-url-input
branch
from
d7723c5 to
c93923e
Compare
Contributor
Author
|
Thanks for the review!
Merged, with that cleanup commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.