feat: moment marker should move dynamically over time#114
Open
L-ZJoker wants to merge 1 commit intozunnzunn:masterfrom
Open
feat: moment marker should move dynamically over time#114L-ZJoker wants to merge 1 commit intozunnzunn:masterfrom
L-ZJoker wants to merge 1 commit intozunnzunn:masterfrom
Conversation
zunnzunn
requested changes
May 19, 2024
Owner
zunnzunn
left a comment
There was a problem hiding this comment.
useNow() is suitable for this use-case, however, you might want to configure this behavior to be more specific. A few things to consider:
- Try playing around with this. If you set a narrow time window (
chart-startandchart-end) in the gantt chart, e.g. a few minutes around the current time), you will notice that the time marker does not move in a, say, 1-second-interval as you'd expect it to. - What if the current time is not within the set time window and therefore not visible anyways? The periodic recomputation of the
xDistof the time marker is a waste of resources then. It'd make sense to check whether the current time is within set boundaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.