feat+doc: added GGanttChart/highlight-sundays#95
Open
N0ah-S wants to merge 2 commits intozunnzunn:masterfrom
Open
feat+doc: added GGanttChart/highlight-sundays#95N0ah-S wants to merge 2 commits intozunnzunn:masterfrom
N0ah-S wants to merge 2 commits intozunnzunn:masterfrom
Conversation
Owner
|
I'll think about how this could be generalized, though having this as an extra option doesn't hurt. |
Contributor
Author
|
Great, if you have any suggestions to improve that feature, I'd be happy to implement them. |
albadedan
added a commit
to albadedan/vue-ganttastic
that referenced
this pull request
Dec 4, 2024
Fix zunnzunn#125 [feat] re-working of zunnzunn#95 Adds new props to handle different methods of highlighting dates and hours. - `highlighted-days-of-week` to handle highlighting the same day or days every week without having to calculate their dates. Useful for highlighting weekends. Set to [0, 6]. - `highlighted-dates` for when you want to highlight specific dates. - `highlighted-hours` for when you are using hour precision. `highlighted-units` probably depreciated now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This functionality partially already exists as 'highlightedDays' but I'd prefer a less involved version for the application using the library, as well as a 'date safer' method.
What
If the option 'highlight-sundays' in GGanttChart is set to true, sundays will be visually highlighted in the chart with a mild opaque color and the dates text color will be changed to a dark red.
Example/Reference