add update endpoint #66
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an update endpoint for mock responses and refactors related helper functions for unified handling of create and update operations. Additionally, it adds a secret field to the bin response interfaces, integrates metadata in storage operations, and updates the API routes documentation accordingly.
- Updated types with a new secret property
- Enhanced storage response to include metadata
- Refactored handlers to support both create and update operations and updated OpenAPI docs
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| modules/types.ts | Added a secret property to the BinResponse interface |
| modules/storage.ts | Extended storage handling by including metadata in GetObjectResult |
| modules/handlers.ts | Refactored logic into helper functions and implemented update endpoint |
| config/routes.oas.json | Updated API schema and routes for the new update endpoint |
Comments suppressed due to low confidence (1)
modules/storage.ts:103
- It appears that 'contentEncoding' is assigned the value of 'response.ContentDisposition', which seems incorrect; consider using 'response.ContentEncoding' instead to avoid potential data mapping issues.
contentEncoding: response.ContentDisposition,
|
The latest build updates on your Zuplo API Gateway. Learn more about Zuplo for GitHub ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.