-
Notifications
You must be signed in to change notification settings - Fork 67
feat: Only deploy docs to production on release tags #1917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ntotten
wants to merge
1
commit into
main
Choose a base branch
from
docs/release-only-production-deploy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| #!/bin/bash | ||
|
|
||
| # Vercel Ignored Build Step script | ||
| # Exit 0 = Skip build | ||
| # Exit 1 = Proceed with build | ||
|
|
||
| # Always build preview deployments | ||
| if [ "$VERCEL_ENV" != "production" ]; then | ||
| echo "Preview deployment - proceeding with build" | ||
| exit 1 | ||
| fi | ||
|
|
||
| # For production: only build if the commit is tagged with a release | ||
| echo "Production deployment - checking for release tag..." | ||
|
|
||
| # Fetch tags from remote (Vercel does shallow clones) | ||
| git fetch --tags --quiet 2>/dev/null || true | ||
|
|
||
| # Check if current commit has a version tag (e.g., v1.0.0, 1.0.0) | ||
| TAGS=$(git tag --points-at HEAD 2>/dev/null) | ||
|
|
||
| if [ -z "$TAGS" ]; then | ||
| echo "No tags found on this commit - skipping production build" | ||
| echo "Production deployments only occur on tagged releases" | ||
| exit 0 | ||
| fi | ||
|
|
||
| # Check if any tag matches a version pattern | ||
| for TAG in $TAGS; do | ||
| if echo "$TAG" | grep -qE '^v?[0-9]+\.[0-9]+\.[0-9]+'; then | ||
| echo "Found release tag: $TAG - proceeding with production build" | ||
| exit 1 | ||
| fi | ||
| done | ||
|
|
||
| echo "No release tags found (tags: $TAGS) - skipping production build" | ||
| exit 0 | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The regex pattern will match prerelease version tags like "v1.0.0-beta" or "v0.0.0-z123abc" because it doesn't anchor at the end of the string. Based on the PR description stating "Production deployments only proceed when the commit has a release tag (e.g., v1.0.0)", it appears the intention is to match only stable release versions, not prereleases. Consider anchoring the pattern at the end with '$' or adding explicit exclusion of prerelease suffixes: '^v?[0-9]+.[0-9]+.[0-9]+$'