Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Zudoku’s Vite integration to Vite 8 (rolldown-powered) and adjusts build/config tooling to support per-environment builds and parallel client/SSR builds, along with required ecosystem and documentation updates.
Changes:
- Upgrade to
vite@8.0.0-beta.16(rolldown) and update related workspace/lockfile entries. - Switch build pipeline to Vite 8’s
createBuilderwithenvironments.client/environments.ssrandrolldownOptions. - Migrate Shiki resolution from deprecated Vite alias
customResolverto aresolveIdhook; adjust schema processing timing for parallel builds; update Node/TS configs/docs.
Reviewed changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Excludes Vite/rolldown/oxc packages from minimum release age gating. |
| pnpm-lock.yaml | Locks upgraded Vite/rolldown/oxc dependency graph and removes direct rollup dependency from zudoku importer. |
| packages/zudoku/tsconfig.node.json | Enables erasableSyntaxOnly for Node TS config. |
| packages/zudoku/tsconfig.app.json | Enables erasableSyntaxOnly for app TS config. |
| packages/zudoku/src/vite/prerender/prerender.ts | Passes --no-deprecation to worker pool processes. |
| packages/zudoku/src/vite/plugin.ts | Switches to new combined Shiki plugin export. |
| packages/zudoku/src/vite/plugin-shiki-register.ts | Adds dedicated Shiki resolveId plugin and exports combined viteShikiPlugin() plugin option. |
| packages/zudoku/src/vite/plugin-api.ts | Moves schema processing to plugin creation time to avoid parallel-build races. |
| packages/zudoku/src/vite/dev-server.ts | Updates config env creation to match new build/environment model (removes isSsrBuild). |
| packages/zudoku/src/vite/config.ts | Migrates to Vite 8 per-environment build config and rolldownOptions; adjusts optimizeDeps/future flags. |
| packages/zudoku/src/vite/build.ts | Reworks build flow to use createBuilder and parallel client/SSR builds. |
| packages/zudoku/src/lib/authentication/errors.ts | Removes TS parameter property (compatible with erasableSyntaxOnly) and assigns explicitly. |
| packages/zudoku/src/config/validators/icon-types.ts | Adds new Lucide icon names to the allowlist. |
| packages/zudoku/src/config/loader.ts | Updates config-loader typing to use Vite build result types (but currently has a type-query issue). |
| packages/zudoku/package.json | Upgrades Vite to v8 beta and removes direct rollup dependency. |
| packages/zudoku/cli.js | Updates Node version requirement messaging/check to >=22.12.0 (or >=20.19.0). |
| examples/with-vite-config/vite.config.ts | Updates example config from rollupOptions to rolldownOptions. |
| docs/pages/docs/quickstart.md | Updates documented Node prerequisite version to 22.12.0+. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Preview build of published Zudoku package for commit d641510. See the deployment at: https://24968a08.cosmocargo-public-package.pages.dev Note This is a preview of the Cosmo Cargo example using the Zudoku package published to a local registry to ensure it'll be working when published to the public NPM registry. Last updated: 2026-03-13T13:51:36.045Z |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
vite@8integration for faster builds via rolldown: https://vite.dev/guide/rolldownChanges
createBuilderenvironments.client/environments.ssr) replaces top-levelbuild.ssrrolldownOptionsreplacesrollupOptionscustomResolvertoresolveIdhook with rolldown hook filterserasableSyntaxOnlyenabled in tsconfigs (required by Vite 8's strip-types)esbuildOptionsfromoptimizeDeps, removedrollupdependencyBreaking changes
See: https://main.vite.dev/guide/migration