fix(docker): serialport prebuilds should be ok now, so can skip rebuilding it#3440
Closed
fix(docker): serialport prebuilds should be ok now, so can skip rebuilding it#3440
Conversation
chrisns
changed the title
Pull Request Test Coverage Report for Build 6997399048
💛 - Coveralls |
robertsLando
requested changes
Nov 26, 2023
Member
robertsLando
left a comment
robertsLando
left a comment
There was a problem hiding this comment.
Without that line and the changes I did related to node_modules, the install will be skipped and so the arm builds will ship with the amd64 binaries of serialport (that will not work at all on arms)
Member
Author
|
hold fire, need to get another PR fixed for serial-port |
Member
Author
|
blocked by serialport/bindings-cpp#163 or move to non-musl (alpine) based image |
Member
|
#3443 fixes all the problems 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.