feat(ui): make header/footer fixed on control panel table#4488
Open
robertsLando wants to merge 3 commits intomasterfrom
Open
feat(ui): make header/footer fixed on control panel table#4488robertsLando wants to merge 3 commits intomasterfrom
robertsLando wants to merge 3 commits intomasterfrom
Conversation
Member
Author
|
@AlCalzone Would like your opinion on this, not sure if the view looks too "trimmed" now |
Pull Request Test Coverage Report for Build 20454402626Details
💛 - Coveralls |
Member
Author
|
cc @AlCalzone |
Contributor
|
I tried it on my macbook and it's a bit too squished when opening the device page |
Member
Author
|
@zackbcom You mean fixing both table header and pagination to the top then? P.S: thanks for the Christmas present, received it few days ago 🙏🏼❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3603