Draft
Conversation
Owner
|
Can you clarify on "Drag&dropping the currently playing song will change the currently playing song"? |
Author
|
If you are currently playing a song in the queue and move it somewhere else, the next song in the queue will start playing instead of the currently playing song still playing. This is because this code touches the queue, but not the currently playing song. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Draft Adds Drag&Drop Queue Control, closing #37 & #595
Current Issues/Limitations:
symphony.radio.play, pausing the music for ~0.5sFixed Problems:
The drag&drop source detectTapGestures interferes with the SongCard Card onClick -> temporarily added Card onClick to Song title/author (could be fixed by using detectTapGestures for both, or limiting the detectTapGestures into its own space with a SongCard shadow)-> moved the drag area out of the onClickuses ExperimentalFoundationApi-> dragAndDrop features aren't Experimental since compose-foundation 1.8Drag&dropping the currently playing song will change the currently playing song-> fixed in second commitUnclear where the drop will land-> moved the drop zones between the queue entries